Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1
According to the GitHub full text search,
x3::_wherehas almost zero use case. We simply remove it now.Additionally, the old codebase allowed semantic action to be defined in a form like
[](auto& ctx) { /* ... */}, which chokes on prvalue context. If we keep that behavior, we must always create a local context variable just for inventing lvalue reference. As a resolution, this PR prohibits lvalue-only functor definition in the first place and guides users to define[](auto&& ctx) { /* ... */ }instead.The removal of
_wherecontext and the temporary context variable results in complete elimination of unused references created by the core parsers, finalizing our context-related optimization in X4.