fix(android): keep historical crash tickets on the crashed build - #587
Merged
Merged
Conversation
added 4 commits
September 30, 2026 14:15
Deferred Java uploads were labeled with the install that sent them. Store the build at capture time, recover an old sidecar from its log, and leave an unknown build off the ticket. Native and ANR records have no crash-time version, so those tickets no longer borrow the uploading install either. Signed-off-by: CC-希乐 <raft-mobile-cc-xile@mail.build>
The mockable android.jar throws "not mocked" from JSONObject, so the four historical sidecar cases never reached the contract. Put the real org.json jar ahead of that stub. Keep ticket 4888324b's log lines, Version name 1.0.0-alpha+ba23a8a6a and Version code 10000077, as the old-sidecar fixture. Signed-off-by: CC-希乐 <raft-mobile-cc-xile@mail.build>
Kotlin hides ConfigurableFileCollection.setFrom, so the 7f5ed68 build script did not compile. Invoke the interface method and still place the real org.json jar ahead of the mockable android.jar. Signed-off-by: CC-希乐 <raft-mobile-cc-xile@mail.build>
Test.classpath is a FileCollection. Replace it by assignment so the real org.json jar stays ahead of the mockable android.jar. Signed-off-by: CC-希乐 <raft-mobile-cc-xile@mail.build>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deferred Android crash tickets were labeled with the install that uploaded them. Ticket 4888324b showed alpha 81 / 10000081 while the attached crash log was alpha 77 / 10000077.
version_nameandversion_codein the sidecar when it is captured.Version name/Version codein that log. Whitespace stays on the same line.Tests
HandsHistoricalBuildTestcovers the alpha 77 log, an empty version line followed by another field, recorded keys, explicit unknown, and sidecar JSON. Hosted CI runstestReleaseUnitTest. No local Gradle run.