fix(uploads): prevent ready assets starving expired cleanup - #588
Merged
Merged
Conversation
Signed-off-by: Volta <volta@mail.build>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expired uploads can remain stuck forever when the cleanup query's oldest 50 rows are completed assets. The cron selects those
readyrows every time, then the cleanup claim rejects them, so newer expired uploads never enter a batch.Exclude
readyuploads from the expired/live selection before ordering and limiting. Completed assets retain their database records and R2 objects. Existing tombstone retries and active-verifier fences stay in place.Production read-only diagnosis: the deployed query's first batch contained 50 ready rows; there were 1,099 expired ready/live rows, and the reported asset remained verifying after its upload deadline. No production state was changed.
Validation: regression cases for both expired pending and verifying uploads behind 50 completed assets fail before the fix, then pass. They verify removal of the expired asset and replay, preservation of all 50 final objects, and redeclaration in the same build with a new asset id. All 31 upload route tests pass; diff check passes. Deployment is separate from this PR.