test: tolerate ETXTBSY when starting the slot fixture - #27
Merged
Merged
Conversation
A parallel test's fork can inherit the writable handle from fs::copy, so exec of the freshly copied fixture briefly fails with ETXTBSY (seen on ubuntu-24.04-arm in #26). Retry the spawn for that error only, within 5s. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: archer <archer@mail.build>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The unit test
product_running_from_the_stable_slot_is_found_and_attested(added in #25) copies/bin/sleepinto the slot and spawns it right away. When another test forks at the same moment, the child can inherit the writable handle fromfs::copy, and exec fails withETXTBSY("Text file busy"). Seen on ubuntu-24.04-arm in #26 (run 36738644144).Fix
Test-only: retry the spawn while it fails with
ExecutableFileBusy, within 5s. Any other error still fails the test immediately.Tests
cargo fmt,cargo clippy -D warnings, and thelegacy_layouttests pass.🤖 Generated with Claude Code