-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pigz for parallel decompression by containerd #2896
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for picking this up!
Overall looks good, but needs a few fixes for some subtle cross-compiling and software licensing issues.
fd2a413
to
9806929
Compare
Thanks for your review, I have fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for working on this! It looks good to me, just a minor nit.
f558123
to
12f7bf5
Compare
Thanks to all reviewers! |
Nice work. Thanks for doing this, @ohkinozomu! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All comments addressed - looks great!
Issue number:
Closes #2886
Description of changes:
Let containerd use pigz (or more precisely,
unpigz
).pigz doesn't have a LICENSE file (madler/pigz#89) and I decided to use
README
...If there is no pigz, and the log level of containerd is set to debug, the following log will be output at the time of pull.
I have confirmed that with this change that log disappears (i.e. containerd uses unpigz).
Here is a quick benchmark.
machine spec:
Google Compute Engine c3-highcpu-22 Ubuntu 22.04.2 (enable nested virtualization)
Command to execute:
without pigz(commit b1ac8ef)
with pigz(this commit)
Testing done: yes
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.