fix(bounty): derive shortlist selection from live application list

[0xdevcollins]

Summary

Follow-up fix to the applications review tab (#670, since merged into feat/t-replace). Originally this branch superseded #670; after that merge it was rebased down to just this one fix commit.

The bug

Declining a checked application unmounted its checkbox but left its id in the checked set, so:

• the sticky-bar count stayed inflated, and
• Approve shortlist submitted a DECLINED application's id.

The fix

The selection is derived from the live list (selectedIds = checked ids still in SUBMITTED) — the count, the button's disabled state, and the shortlist payload only ever include actionable applications.

Review notes from #670 (non-blocking, not addressed here)

• useInvalidateApplications re-derives the 'org-applications' key literal instead of using a bountyKeys helper — drift risk.
• retry: false on the list query deviates from the global query defaults without a comment.
• An empty decline reason is sent as "" instead of omitted.
• videoIntroUrl / portfolioLinks are applicant-supplied and rendered as hrefs without scheme validation (same pattern as the submissions panel — candidate for a shared helper).

Verification

tsc --noEmit — 0 errors on this head (rebased onto current feat/t-replace).

🤖 Generated with Claude Code

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
boundless-kd16	Ready	Preview, Comment	Jul 5, 2026 1:11pm

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 4ada30ac-fffc-4754-ba0f-aaeefad58ff9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feat/bounty-applications-review-fixed

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}