Skip to content

fix(ci): restore --with-deps on Playwright install#267

Merged
Benjtalkshow merged 1 commit into
boundlessfi:mainfrom
Benjtalkshow:fix/restore-playwright-with-deps
May 31, 2026
Merged

fix(ci): restore --with-deps on Playwright install#267
Benjtalkshow merged 1 commit into
boundlessfi:mainfrom
Benjtalkshow:fix/restore-playwright-with-deps

Conversation

@Benjtalkshow

@Benjtalkshow Benjtalkshow commented May 31, 2026

Copy link
Copy Markdown
Contributor

PR #265 dropped --with-deps from the Playwright install step in .github/workflows/ci.yml. Without it, fresh CI runners without Chromium's system libs (fonts, shared libraries) cached will fail to launch the browser.

Restoring --with-deps so e2e stays reliable across cold runners.

Summary by CodeRabbit

  • Chores
    • Updated E2E test environment setup to ensure all required system dependencies are properly installed before running tests.

PR boundlessfi#265 dropped --with-deps from the Playwright install step. Without it,
fresh CI runners that don't have Chromium's system libs (fonts, shared
libraries) cached will fail to launch the browser. Putting it back.
@vercel

vercel Bot commented May 31, 2026

Copy link
Copy Markdown

@Benjtalkshow is attempting to deploy a commit to the Threadflow Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitai Bot commented May 31, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

This PR updates the CI workflow to install Playwright Chromium with system dependencies enabled in the E2E test job. The --with-deps flag ensures all required system libraries are available before E2E tests run.

Changes

E2E Playwright dependencies

Layer / File(s) Summary
Chromium installation with system dependencies
.github/workflows/ci.yml
The test-e2e workflow step adds --with-deps to pnpm exec playwright install chromium, ensuring system dependencies required by Chromium are installed during CI setup.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A single flag hops into place,
Chromium's deps now embrace,
The system libraries, snug and tight,
E2E tests shall run just right!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly and specifically describes the main change: restoring the --with-deps flag on Playwright install in CI configuration, which matches the primary objective of the pull request.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
.github/workflows/ci.yml (1)

96-97: Consider caching Playwright browsers to speed up CI runs.

Currently, Playwright browsers are downloaded and system dependencies installed on every CI run. Adding a cache step for Playwright browsers could reduce CI execution time and bandwidth usage.

💡 Suggested cache configuration

Add this step before "Install Playwright Chromium":

- name: Cache Playwright browsers
  uses: actions/cache@v4
  with:
    path: ~/.cache/ms-playwright
    key: ${{ runner.os }}-playwright-${{ hashFiles('**/pnpm-lock.yaml') }}
    restore-keys: |
      ${{ runner.os }}-playwright-

Note: With caching, Playwright will skip downloading browsers if they're already cached, but --with-deps will still ensure system dependencies are installed when needed.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/ci.yml around lines 96 - 97, Add a cache step before the
"Install Playwright Chromium" step to store Playwright browsers under the
~/.cache/ms-playwright path using actions/cache@v4; configure the cache key to
include runner.os and a hash of pnpm-lock.yaml (e.g.,
${runner.os}-playwright-${hashFiles('**/pnpm-lock.yaml')}) and use a
restore-keys prefix like ${runner.os}-playwright- so cached browsers are
restored when available; keep the existing "Install Playwright Chromium" step
(which runs pnpm exec playwright install chromium --with-deps) so system
dependencies are still ensured even when browsers are cached.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In @.github/workflows/ci.yml:
- Around line 96-97: Add a cache step before the "Install Playwright Chromium"
step to store Playwright browsers under the ~/.cache/ms-playwright path using
actions/cache@v4; configure the cache key to include runner.os and a hash of
pnpm-lock.yaml (e.g., ${runner.os}-playwright-${hashFiles('**/pnpm-lock.yaml')})
and use a restore-keys prefix like ${runner.os}-playwright- so cached browsers
are restored when available; keep the existing "Install Playwright Chromium"
step (which runs pnpm exec playwright install chromium --with-deps) so system
dependencies are still ensured even when browsers are cached.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ea42beba-d304-4ead-a483-0d3af86fc33e

📥 Commits

Reviewing files that changed from the base of the PR and between d02b2d5 and 88c47e9.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml

@Benjtalkshow Benjtalkshow merged commit d456e91 into boundlessfi:main May 31, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant