Skip to content

fix(content-sharing): omit unchanged shared link expiration - #4884

Draft
jpan-box wants to merge 1 commit into
box:masterfrom
jpan-box:fix-omit-unchanged-shared-link-expiration
Draft

jpan-box wants to merge 1 commit into
box:masterfrom
jpan-box:fix-omit-unchanged-shared-link-expiration

Conversation

@jpan-box

@jpan-box jpan-box commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

MOTIVATION

Desktop Content Sharing sent the existing link expiration on every save. The date stored for the modal is local midnight, so it can differ from the timestamp already on the file even when the calendar day is the same. When the caller cannot change that date, the save fails and the modal shows an error.

BEFORE

  • Save sends the expiration date when the switch and the calendar day did not change
  • That save fails when the caller cannot change the expiration date

AFTER

  • Save leaves the expiration date out when the switch and the calendar day did not change
  • That save succeeds

@coderabbitai

coderabbitai Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jpan-box
jpan-box force-pushed the fix-omit-unchanged-shared-link-expiration branch from 760a234 to 1f2ca7d Compare October 6, 2026 15:35
@jpan-box
jpan-box force-pushed the fix-omit-unchanged-shared-link-expiration branch from 1f2ca7d to 9fe48b1 Compare October 6, 2026 15:37

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant