Repository navigation
Conversation
Replace the NID-only stub with the real one-pointer signature and the common-dialog guards: NOT_INITIALIZED before sceWebBrowserDialogInitialize, ARG_NULL for a null param, success otherwise. The param is accepted and discarded, as no browser session exists to store the cookie; the 280-byte WebBrowserDialogSetCookieParam layout (size, url, cookie, 256 reserved bytes) is taken from SharpProspero and disclosed in TechnicalDebt.md, which also drops WebBrowserDialog from the unknown-signature list.
Saalik
force-pushed
the
feat/webbrowserdialog-set-cookie
branch
from
October 6, 2026 23:16
66be739 to
fa3bbf8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Implements
sceWebBrowserDialogSetCookie, the last unimplemented export oflibSceWebBrowserDialog, replacing the NID-only stub:sceWebBrowserDialogSetCookie(WebBrowserDialogSetCookieParam*)binding in WebBrowserDialog.csCOMMON_DIALOG_ERROR_NOT_INITIALIZEDbeforesceWebBrowserDialogInitialize,COMMON_DIALOG_ERROR_ARG_NULLfor a null paramTested
guest_web_browser_dialog: SetCookie before Initialize returnsNOT_INITIALIZED; a null param after Initialize returnsARG_NULL; a param is accepted after Initialize and after Open (any initialized state); builds and passes on LinuxChecklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed in TechnicalDebt.mdfiles or images added to the repository (attach them to this PR)Written with AI assistance (Cline). The SharpProspero layout was fetched and verified against the linked source; the semantics follow the other silent dialogs and the disclosure lives in TechnicalDebt.md.