Repository navigation
test(agc): fix the stale 32-bit WriteWait expectation and run the full suite - #1006
Merged
oneandonlydean merged 1 commit intoOct 7, 2026
Merged
Conversation
…l suite WriteWait has truncated the reference and mask of a 32-bit wait since 9c2a756 ("relaxed checks for what titles send"), but testMemory still expected a reference above 32 bits to throw, so agc_command_tests failed when run without arguments. ctest only registers the "defaults" mode, so the stale expectation was never noticed. Update the expectation to the truncating behaviour (the packet keeps the low halves) and register the full mode as agc_commands so the packet, marker, flip, register and memory cases are checked again. Closes boykopovar#1005.
9 tasks done
9 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes the stale expectation in
testMemoryand registers the fullagc_command_testsmode in ctest. Closes #1005.WriteWaittruncates the reference and mask of a 32-bit wait (size == 0) to their low halves since 9c2a756 ("relaxed checks for what titles send"), buttestMemorystill expected a reference above 32 bits to throw, so the binary failed when run without arguments:Only
agc_initialization(agc_command_tests defaults) is registered in ctest, so the stale expectation went unnoticed and the packet, marker, flip, register and memory cases have not been running.testMemory: the secondexpectFailurebecomes an assertion that the packet keeps the low halves of the reference and mask (0x100000000→ 0,0xffffffff00000001→ 1). Thestorage.words == beforecheck now covers only the remainingsceAgcWaitRegMemPatchReferencefailure.CMakeLists.txt: addagc_commands(agc_command_testswith no arguments) next toagc_initialization, so the full mode runs in CI.Tested
./build/tests/agc_command_tests→expected an exception, exit 1.AGC command tests passed, exit 0.ctest -R '^agc_(initialization|commands)$'→ both pass.ctest --test-dir build -j 8 --timeout 120→ 370/370 pass.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed in TechnicalDebt.mdfiles or images added to the repository (attach them to this PR)