Repository navigation
feat(libressl): implement certificate verification error strings - #10065
Merged
oneandonlydean merged 1 commit intoOct 23, 2026
Merged
oneandonlydean merged 1 commit into
oneandonlydean merged 1 commit into
Conversation
|
Other open pull requests touch the same code. Merging one will break the other, or both implement the same thing. If this one builds on them, list them in Depends on.
Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.
|
This was referenced Oct 23, 2026
12 tasks done
atharvjairath
force-pushed
the
feat/libressl-x509-error-strings
branch
from
October 23, 2026 11:07
c4b1fa5 to
30ab85a
Compare
12 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Implement
X509_verify_cert_error_string_nid_postfix, so callers receive the LibreSSL 2.5.4 diagnostic instead of an unsupported-export exception. The implementation covers all 54 named messages, the numeric fallback (including code 1 and newer error codes), low-32-bit lookup with a 64-bit guest argument, and the shared fallback-buffer lifetime.The contract comes from LibreSSL 2.5.4 x509_txt.c and its error constants. Published firmware 13.40 measurements identify libSceLibreSsl as 2.5.4. I have not independently measured this export on a console; that limitation and the upstream shared-buffer concurrency restriction are recorded in the existing debt file.
The existing progress scanner counts one additional completed export (libSceLibreSsl: 23 to 24 of 399), approximately +0.009 percentage points overall. This is a function-coverage measure, not a game-compatibility claim. No dependency on #10047 or #10056.
Tested
Tested head:
30ab85a8db3496c937d4f701bdd28c1c365524df, rebased onto maine3d03fbae64e1b49e5d4e84e753ccce6edf60da5after #9047 merged. Main's DES implementation, test registration and debt entry are preserved; pending-export counts are reconciled. The original PR head is retained as a local recovery reference.not implementedexception before implementation. This refresh reruns the complete focused suite on the head above.git diff --checkpass. The refreshed overlap scan reports debt-count conflicts with feat(libSceLibreSsl): implement ASN.1 integer and string helpers #10005/feat(libSceLibreSsl): implement AES key schedule, block and mode functions #10151. I inspected the shared-file diffs of base-conflicted feat(libSceLibreSsl): implement the low-level AES functions #9033/feat(libSceLibreSsl): implement RAND and the CRYPTO allocator functions #9041/feat(libSceLibreSsl): implement the BN_ BIGNUM, BN_CTX, conversion, word, BN_mul and BN_mod_inverse functions #9446/feat(libSceLibreSsl): implement the EVP message digest and HMAC functions #9448/feat(libSceLibreSsl): implement the per-thread error queue #9529/feat(libSceLibreSsl): implement CMAC with AES-CBC methods #9571/feat(libSceLibreSsl): return the measured version from SSLeay #9745/feat(libSceLibreSsl): implement TLS alert descriptions #9870/feat(libSceLibreSsl): implement five custom UI method functions #9942/feat(libSceLibreSsl): implement the OCSP status and reason strings #9949/feat(libressl3): report OpenSSL version strings #9970 and the other two independent LibreSSL follow-ups: none implements this PR's exports. Shared include declarations, CMake test insertions and debt counts will need reconciliation as those PRs land. The scan also lists this PR's pre-rebase revision as a self-comparison; that is not competing work.These are focused builds of the real libSceLibreSsl, libSceLibreSsl3 and complete libc targets. They now configure main's SSL backend to build the repository-pinned mbedTLS crypto dependency from source, alongside pinned ZArchive/zstd; there are no library-behavior or exception-sentinel mocks. Whole-project configuration remains blocked by uninitialized SDL2 and missing XRandR development support. No whole-project, native Windows desktop, title or console run is claimed. A collaborator must dispatch the upstream Build workflow for full Linux/Windows CI.
Focused runtime build recipe
Use the following CMake project outside the source tree, with the repository-pinned ZArchive, zstd and mbedTLS checkouts under its
3rdparty/directory (mbedTLS068ff080b369adfac81509f9b57b2afabaf82dc5, including its pinned framework submodule):Configure with
-DANYPS5_SOURCE_ROOT=<checkout> -DCMAKE_BUILD_TYPE=Release, build, then runctest --test-dir <build> --output-on-failure. On Linux in this environment,CMAKE_CROSSCOMPILING_EMULATORpoints to QEMU x86-64. Windows uses WinLibs GCC 15.2.0 UCRT r7; the Windows test executables run through Wine 9 under QEMU, with the build directory, both LibreSSL library directories and the WinLibs bin directory onWINEPATH. Each test keeps its repository timeout.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)