Repository navigation
Conversation
9 tasks done
9 tasks done
Collaborator
|
Closing, for the same reason as #980: this PR decodes the instruction but translation only throws, so a shader using it fails just as it did on You're welcome to reopen if you have a real translation: the op working end to end, an execution test that pins values, and the semantics measured on hardware or cited from a source. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Implement decoding and dispatch for AMD RDNA 2 Data Share instruction
DS_GWS_INIT(opcode0x99).Provenance: AMD "RDNA 2" Instruction Set Architecture Reference Guide, Section 9: Data Share Instructions.
Why
Increases RDNA 2 instruction coverage in the shader recompiler and enables disassembly and structured handling of Global Wave Sync (GWS) resource initialization operations on GDS.
How
DsGwsInittoRdnaOpcodeenum.0x99uindsOpcodestable with 1 source operand (data0/vdata).DecodeRdnaDsrequiringgdsflag and validating unused register operands (addr,data1,vdstmust be 0).MemoryInstructionDispatch.cppthrowing runtime exception on unsupported translation.core/libs/tests/DsGwsInit.cppcovering valid decode with GDS, non-GDS rejection, invalid register operands rejection, and translation throw path.