Repository navigation
Conversation
MarcZX10
left a comment
There was a problem hiding this comment.
Reviewed current head 87bdf54. Resolving viewedBytes before RequireNoMultisampleTarget closes the first-byte-only gap for callers that have not precomputed a surface size, and the check now precedes both native-depth storage handling and cached lookup. The regression exercises an overlapping cached range and an adjacent disjoint range ending exactly at the native depth boundary, then checks owner retirement and byte preservation. The author reports 47 focused Windows GPU checks with Vulkan required, shader cache disabled and validation layers confirmed, no new VUIDs; I did not run the GPU test locally. Hosted eligibility, conventions, intake, labels and report pass; product jobs are skipped by path policy. git diff --check upstream/main...upstream/pr/10368 passes. I found no blocking issue.
|
Other open pull requests touch the same code. Merging one will break the other, or both implement the same thing. If this one builds on them, list them in Depends on.
Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.
|
|
Intel run, a second vendor next to the RTX 4070 Ti SUPER. Setup: Intel Arc Graphics (Meteor Lake,
AI-assisted: yes (Claude Code) |
What
A storage-image lookup without a precomputed surface size checked only its first byte against native multisample owners. A native depth surface inside a larger cached view was missed, so the cache could return stale guest bytes and keep the overlapping native owner active.
Resolve the viewed surface's complete size before the overlap check and use that range before either the native-depth storage path or a cached storage lookup. The regression seeds a cached linear view, creates an unwritten native multisample depth surface inside it, checks a disjoint view ending at the depth boundary, then requires the complete view to retire the intersecting owner without changing guest bytes.
Tested
Windows 11 Pro build 26300, WinLibs GCC 15.2.0, Release, NVIDIA GeForce RTX 4070 Ti SUPER, NVIDIA 617.42.
a cached storage view kept a native depth owner inside its range.Overlap review: 31 shared-file PR diffs checked. #10049 adds overwrite coverage while retaining the one-byte fallback; this fix uses the complete span and needs a small textual merge with that call-site change. #10064 changes committed 3D slabs. The native-depth fixture additions in #6808/#9950 cover other behavior. None implements this full-span check.
Independent validation of the published commit: Published head
87bdf5445d747ddc76f0cedcb31579e9900aa9c1: full Windows Release build and native multisample depth, depth-storage dispatch, native-depth BDA clear/retirement/clear/refusal checks and patched-library validation pass on a clean tracked tree without overlays (7/7, zero skips). Vulkan is required, shader caches are disabled, and loader logs confirm actual Khronos instance/device validation layers; no VUIDs. Hardware and toolchain are the Windows/NVIDIA configuration listed above. This independently validates the published commit in addition to the earlier integration runs. The complete CTest suite was not run.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)