Repository navigation
fix(agc): read unwritten user data registers as zero - #1037
Merged
oneandonlydean merged 1 commit intoOct 7, 2026
Merged
Conversation
A stage's user data registers are read for the count in its RSRC2 (COMPUTE_PGM_RSRC2 for compute). A register the title never wrote no longer refuses the draw or dispatch: it reads 0, as Kyty and SharpEmu read it and as AMD PAL and Mesa initialize the user data registers. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Other open pull requests touch the same code. Merging one will break the other, or both implement the same thing. If this one builds on them, list them in Depends on.
|
9 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A stage's user data registers are read for the count in its RSRC2 (COMPUTE_PGM_RSRC2 for compute). A register the title never wrote used to refuse the draw or dispatch with "required shader register has not been written". It now reads 0.
Tested
Linux (CachyOS), x86-64, GCC, 7800X3D / RTX 4090.
Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed in TechnicalDebt.mdfiles or images added to the repository (attach them to this PR)