Repository navigation
Conversation
|
Other open pull requests touch the same code. Merging one will break the other, or both implement the same thing. If this one builds on them, list them in Depends on.
Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.
|
d5b6d9b to
1f77c2f
Compare
1f77c2f to
15ea8e9
Compare
jotitadev
left a comment
There was a problem hiding this comment.
Linux run of the full build, since the description reports a standalone compile with a shim.
Machine: Linux x86_64, i7-8700 (6 cores / 12 threads, AVX2), Ubuntu 26.04, GCC 15.2, Release, BUILD_TESTING=ON. Head 15ea8e9e2 merged onto main e2d457be3 (clean).
- Build ok. All 19
libressltests pass,guest_libressl_pkey_idamong them (20 of 20 repeated runs), pluspatched_libraries. - Restoring the throwing stub and keeping the test aborts
guest_libressl_pkey_idwithEVP_PKEY_id_nid_postfix not implemented. - Moving the export to
src/PkeyId.cppkeeps it patched. In the patchedlibSceLibreSsl.prx, it is exported asyPuxTL2GJO0, at the same address asEVP_PKEY_id_nid_postfixin the unpatched build.
Written with AI assistance (Claude Code). I ran the builds and tests above on my machine.
15ea8e9 to
88f938d
Compare
|
Head moved to |
88f938d to
20a2172
Compare
20a2172 to
dcc5eb1
Compare
…ary header The public header audit wants exactly one declaration per export, in the library header: the exports the PR adds are declared in Api.hpp with their definitions' signatures, a placeholder with no parameters takes the definition's signature, and the copies in tests and other sources are replaced by an include of the header.
dcc5eb1 to
39568ac
Compare
What
Implement the missing
EVP_PKEY_idexport inlibSceLibreSsl. The function returns the stored key type unchanged. The implementation follows LibreSSL 2.5.4:EVP_PKEYbegins with anint type, andEVP_PKEY_idreturns that field (implementation, structure). The cited firmware discussion identifies LibreSSL 2.5.4, but this layout has not been independently verified on a PS5.The regression test covers unchanged return values across representative identifiers and the null-input throw required by this repository's unimplemented-path convention. Null is dereferenced in the reference implementation.
Tested
Linux host, GCC, C++20: manually compiled the implementation and focused test source with
-Wall -Wextra -Werror, using a small local shim for the repository's throw helper; the test passed.python3 tools/check_conventions.py --base upstream/mainandgit diff upstream/main...HEAD --checkpass. The full CMake target, Windows, a title, and console behavior were not tested.The exact symbol was searched in the open PR queue and no PR implementing
EVP_PKEY_idwas found. The full-queue overlap scan could not finish, so I ran the repository overlap comparison against the active LibreSSL PR refs affecting these files. It found line conflicts atCMakeLists.txt:1anddebt/libSceLibreSsl.md:5with #10398, #10395, #10373, #10376, and #9529; and at the debt count with #10071. It found no duplicate export. #10005 shares the relevant files but could not be compared because that branch conflicts with currentmain. I proposed that #10398, #10395, and #10005 land first, with this branch rebased afterward, and asked those authors to confirm. This draft remains pending their sequencing responses.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)