Repository navigation
refactor(recompiler): share the stage input info helpers - #1069
Merged
adriadam10 merged 1 commit intoOct 7, 2026
Merged
Conversation
StageOf, VertexInfo, PixelInfo and ShaderWorkgroupInput were defined in the anonymous namespaces of up to three SPIR-V backend sources with identical bodies; they are now declared next to FailEmit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
|
Checked that the moved bodies and messages match the removed copies and that no other copy is left; build and ctest (395/395) green on the PR merged onto current |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Four helpers were defined with identical bodies in the anonymous namespaces of several SPIR-V backend sources:
StageOfSpirvModuleSetup.cpp,SpirvInputOutput.cpp,SpirvDescriptors.cppPixelInfoSpirvModuleSetup.cpp,SpirvInputOutput.cpp,SpirvEmitterHelpers.cppVertexInfoSpirvModuleSetup.cpp,SpirvInputOutput.cppShaderWorkgroupInputSpirvModuleSetup.cpp,SpirvBufferAccess.cppSpirvEmitterHelpers.hpp, next toFailEmit(refactor(recompiler): share the SPIR-V emission failure helper #832), which they call, and defined inSpirvEmitterHelpers.cpp; bodies and messages are unchangedSpirvModuleSetup.cppthe anonymous namespace held only these four and is removedSpirvEmitterHelpers.hppNo behaviour change.
Tested
Windows 11, MinGW-w64 GCC 15.2.0 (WinLibs r7), Release with
BUILD_TESTING=ON, onmain80d4f6b. No title or homebrew.ctest: 382/383 passed, the failure is agc_driver_vopc_compare_table fails in wave32 for LG compares in the e32 encoding on AMD RDNA 3.5 #825, which also fails on unmodifiedmainon this AMD GPU.git merge-treegives no new conflicting file and no conflict hunk in the six changed files; the seven that conflict withmainconflict in the same files either way. No open PR adds its own copy of these helpers.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed in TechnicalDebt.mdfiles or images added to the repository (attach them to this PR)🤖 Generated with Claude Code