Repository navigation
fix(macos): hide libSceSsl's static mbedtls symbols - #10877
Closed
krishalivaibhav wants to merge 1 commit into
Closed
krishalivaibhav wants to merge 1 commit into
krishalivaibhav wants to merge 1 commit into
Conversation
Apple ld has no --exclude-libs, so the prx's mbedtls copy was bound to the one linked into test executables, and its pool allocator (installed with mbedtls_platform_set_calloc_free) served the test server's threads, which have no pool. Unexport the mbedtls symbols on Apple. Co-authored-by: Himansh Raj <iamthehimansh@gmail.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 25, 2026
Contributor
Author
|
Closing as a duplicate of #10530 (maximilianfv), which fixes the same mbedtls symbol clash and was opened first. For #10530: on M2 (macOS 27.2, x86_64 Release), with the mbedtls symbols kept out of libSceSsl's exports and #10876 applied, AI-assisted: yes (Claude Code) |
12 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
On Linux and MinGW,
libSceSsllinks its static mbedtls with--exclude-libs,ALL. Apple ld has no such option, so on macOS the prx exported its mbedtls symbols and the dynamic linker bound them to the copy linked into the test executables. The prx's pool allocator, which is installed withmbedtls_platform_set_calloc_free, then served the test server's threads, which have no pool, andguest_ssl_transport_kernelandguest_ssl_transport_netfailed.This PR adds an
elseif(APPLE)branch that links with-unexported_symbol,_mbedtls_*. The existing Linux/MinGW branch is unchanged. The approach follows iamthehimansh'sfeat/macos-port(#8658), and iamthehimansh is credited as co-author.Tested
macOS: Apple Silicon M2, macOS 27.2, AppleClang, x86_64 Release, on a local integration of
main+ #10419 + #10366 + #10369 + #7631 + #7804 + #4630 + #10552 + #10853 + #10876 + this commit:guest_ssl_transport_kernelandguest_ssl_transport_netpass. Without this commit, they fail;guest_ssl,guest_ssl_load,guest_ssl_ps5_readers,guest_http,guest_http2,guest_http_optionsandguest_http_response_headerpass;ctest -R '^(guest_|libc_|libkernel_)': no new failures.Linux/Windows: not built locally. Only an Apple branch is added.
Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository🤖 Generated with Claude Code