Repository navigation
feat(libSceFios2): implement file, directory and operation exports - #12269
Merged
oneandonlydean merged 8 commits intoNov 2, 2026
Merged
Conversation
Add the shared FIOS2 runtime: one handle number space for operations, files and directories, operation records with completion callbacks, suspend and resume with queued operations, cancellation, default operation attributes and the stored initialization parameters. Implement the control exports (sceFiosInitialize, sceFiosTerminate, suspend and resume, the sceFiosGetAll* enumerations, sceFiosOp*) and the path queries sceFiosExists, sceFiosFileExists, sceFiosDirectoryExists, sceFiosFileGetSize and sceFiosStat with their Sync forms on top of sceKernelStat. Failures return SCE_FIOS_ERROR_* codes. The prototypes and layouts come from public emulator sources and are listed in docs/dev/debt/libSceFios2.md.
Implement sceFiosDelete, sceFiosFileDelete, sceFiosDirectoryCreate, sceFiosDirectoryDelete, sceFiosRename, sceFiosFileRead, sceFiosFileWrite and sceFiosFileTruncate with their Sync forms on top of the kernel file exports, so guest path mapping and archive handling stay in one place. Reads and writes loop until the request is satisfied or the file ends, argument and kernel failures map to SCE_FIOS_ERROR_* codes, and the test covers the error paths and the operation counters.
Implement sceFiosFHOpen, sceFiosFHOpenWithMode, sceFiosFHClose, sceFiosFHStat, sceFiosFHTruncate, sceFiosFHSync, the read, write, pread and pwrite families including the vectored forms with their Sync variants, and sceFiosFHSeek, sceFiosFHTell, sceFiosFHGetSize, sceFiosFHGetPath and sceFiosFHGetOpenParams. A handle owns a kernel descriptor and serializes its transfers. Transfers the open flags exclude, bad vector counts, negative sizes and offsets and closed handles return SCE_FIOS_ERROR_* codes.
Implement sceFiosDHOpen, sceFiosDHRead, sceFiosDHClose, their Sync forms and sceFiosDHGetPath. Opening lists the directory through sceKernelGetdirentries and reports SCE_FIOS_ERROR_BAD_SIZE with the required size through sceFiosOpGetActualCount when the supplied buffer is null or too small, the sizing probe title code performs. Reading fills SceFiosDirEntry and ends with SCE_FIOS_ERROR_EOF.
Implement sceFiosDateGetCurrent, sceFiosDateFromComponents, sceFiosDateToComponents, sceFiosTimeIntervalFromNanoseconds and sceFiosTimeIntervalToNanoseconds. Dates are nanoseconds since the Unix epoch in UTC, converted with a proleptic Gregorian calendar that does not depend on the host C library, and out-of-range components are normalized.
Keep each entry under the length the conventions check expects.
Progress report (b99bbeb → dddc4fd)📈 System libraries: 47.46% (+0.75%, +106 implemented functions) ✅ 106 implemented
⚪ 2 behaviourally empty (constant return or throw)
Changed libraries (implemented exports)
|
Collaborator
|
@MarcZX10 the structure reads well: every path goes through the kernel exports, so app0/archive mapping stays in libkernel, callbacks fire outside the runtime lock (deleting an op from its own completion callback works), and the 62 exports without a source still throw. One design point on operation completion: every operation runs and fires |
Collaborator
|
@MarcZX10 two small things on the debt file, and one optional:
|
Contributor
|
A Windows run, since the description lists none. Head
AI-assisted: yes (Claude Code). |
Contributor
|
verdict: should-fix
Freshness envelope: head 1126d89; merge-base 9fc181d; behind current main: 73; git merge-tree --write-tree origin/main pull/12269: exit 0, clean. Cross-PR ledger: pr_overlap.py checked 1,372 other open PRs and found no shared files or exports. |
Copy SceFiosOpAttr, SceFiosOpenParams, SceFiosParams, the vector arrays and struct tm out of guest memory with GuestCopyIn instead of dereferencing them, and return SCE_FIOS_ERROR_BAD_PTR when a copy fails. The *Sync forms return the error of an operation that was never created, and the test covers unreadable attributes, open parameters and vector arrays.
Cite the PC port that supplied PS4 call-site evidence by owner, commit and title IDs instead of its repository name, split the file handle entry under the length the conventions check expects, and record the operation threading and guest input handling in the technical debt.
Contributor
Author
|
Pushed two follow-up commits.
|
This was referenced Oct 28, 2026
Contributor
|
Windows result for head Host: Windows 11 26300, Intel i7-12700K, WinLibs GCC 15.2.0 (x86_64-ucrt-posix-seh, r6), Release, The tree also carried the open PRs #12290, #12288, #12285, #12265, #12232, #12206, #12201, #12199, #12197, #12165, #12146, all merged cleanly, so the run is a joint one; the tests of this PR are AI-assisted: yes (Claude Code), the runs and the numbers above are from this machine. |
This was referenced Oct 28, 2026
12 of 13 tasks
12 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Implements 106 of the 168 libSceFios2 exports that only threw
NotImplemented_nid_no_patchthrough parameterless declarations, on top of the kernel file exports (sceKernelOpen,sceKernelPread,sceKernelGetdirentries, ...), so guest path mapping and archive handling stay in libkernel. The library gets aCMakeLists.txt, its own types header and a shared runtime.sceFiosInitialize,sceFiosTerminate,sceFiosIsInitialized,sceFiosUpdateParameters, default operation attributes (global and per thread), suspend and resume with queued operations,sceFiosCancelAllOps,sceFiosShutdownAndCancelOps,sceFiosCloseAllFiles,sceFiosIsIdle,sceFiosGetAllFHs/DHs/Ops,sceFiosIsValidHandleand thesceFiosOp*lifecycle (wait, sync wait, error, counts, attr, path, buffer, offset, cancel, delete, callbacks).sceFiosExists,sceFiosFileExists,sceFiosDirectoryExists,sceFiosFileGetSize,sceFiosStat(plus Sync forms).sceFiosDelete,sceFiosFileDelete,sceFiosDirectoryCreate,sceFiosDirectoryDelete,sceFiosRename,sceFiosFileRead,sceFiosFileWrite,sceFiosFileTruncate(plus Sync forms).sceFiosFHOpen,sceFiosFHOpenWithMode,sceFiosFHClose,sceFiosFHStat,sceFiosFHTruncate,sceFiosFHSync, the read/write/pread/pwrite families including the vectored forms (plus Sync forms),sceFiosFHSeek,sceFiosFHTell,sceFiosFHGetSize,sceFiosFHGetPath,sceFiosFHGetOpenParams.sceFiosDHOpen,sceFiosDHRead,sceFiosDHClose(plus Sync forms),sceFiosDHGetPath.sceFiosDateGetCurrent,sceFiosDateFromComponents,sceFiosDateToComponents,sceFiosTimeIntervalFromNanoseconds,sceFiosTimeIntervalToNanoseconds.Sources (references for prototypes and behaviour only, code written independently, all cited with commits in
docs/dev/debt/libSceFios2.md): RPCS3's Vita FIOS2 module (jacquesjk/RPCS-DX12 mirror ofEmu/ARMv7/Modules/sceFios.*), kalaposfos13/fios2, sonny-tel/libSceFios2, Inori/GPCS4, SonicMastr/SceLibcPosix and vascon-es (a PC port of a PS4 title, CUSA01176 and CUSA00935 version 01.24; call-site evidence for the stat, directory entry and directory-open sizing behaviour).Not implemented, still throwing, because no credible public prototype or behaviour was found: archive mount/unmount and buffer-size exports, overlays,
sceFiosResolve*, IO filters, the cache prefetch/flush/contains family,sceFiosDirectoryCreateWithMode,sceFiosFHToFileno,sceFiosFilenoToFH,sceFiosPathcmp/ncmp/Normalize,sceFiosOpWaitUntil,sceFiosOpReschedule*,sceFiosOpSetBuffer, the debug dump, printf and timestamp exports,sceFiosTimeGetCurrent,sceFiosDLL*,sceFiosDeallocatePassthruFH. No open PR touches libSceFios2 (searchedlibSceFios2; the only hit is an unrelated draft).Known gaps are in the debt file: operations run on the calling thread (no IO threads, deadlines or priorities), error mapping from kernel errors is chosen here, and the dir-open required size is not the console's value.
Tested
Linux (host build, Release + tests).
guest_fios2(new,core/libs/tests/GuestFios2.cpp) exercises the error paths, callbacks, suspension and cancellation, whole-file and handle I/O including vectored and positioned transfers, directory listing with the sizing probe, and date conversion against a known epoch value.check_conventions.pyand the public header audit pass. Not tested on a console or with a title; the prototypes and behaviour are reasoned from the public sources above.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)