Repository navigation
Conversation
Progress report (3a2b919 → e4044fe)📈 System libraries: 45.92% (+0.01%, +2 implemented functions) ✅ 2 implemented
Changed libraries (implemented exports)
|
|
The checklist says no other open PR implements these functions, but two older open PRs do:
I ran Suggestion: drop the three exports from this PR, or close it and offer the parts #9161 lacks there. The |
|
Thanks for the work here. Closing because the whole PR duplicates older open PRs:
Some of your test rows look useful for #9161 ( |
|
Other open pull requests touch the same code. Merging one will break the other, or both implement the same thing. If this one builds on them, list them in Depends on.
Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.
|
|
@rooklz, @adriadam10 Thanks for identifying the duplicate exports. I agree with the closure: #12687’s |
What
Implement the
pwrite,futimesatandsymlinkatexports inlibkernel_sys.pwriteforwards to libkernel's existing positioned-write implementation.futimesatresolves paths with the supplied directory descriptor and uses libkernel's native timestamp implementation.symlinkatshares the existingsymlinkimplementation and path resolution.Firmware 13.60 evidence:
pwriteatlibkernel_sysVA0x13630passes the four POSIX arguments to syscall 476. FreeBSD 11.4 syscall definitions support thefutimesatandsymlinkatprototypes. The currentsymlinklimitations remain: absolute targets and targets containing..throw as unimplemented. Directory-relative host paths also do not model guest aliases or constrain..to the guest root. Console results remain unverified; details are recorded indocs/dev/debt/libkernel_sys.md.Tested
Windows with WinLibs GCC 15.2: configured the full project, built
guest_kernel_sys_tests, and passedctest --test-dir build-win -R '^guest_kernel_sys$' --output-on-failure. The test covers all three exports and error cases.python3 tools/check_conventions.py --base origin/mainpassed.python3 tools/pr_overlap.py --branch feat/libkernel-sys-posix-file-opsscanned 1,410 open PRs and found no overlap. Linux was not tested.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)