Repository navigation
Conversation
|
Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a dedicated DES ECB known-answer suite with 34 key/plaintext/ciphertext triples, repeated encryption, in-place decryption, schedule reuse and buffer guards. Schedule storage is explicitly aligned, with 16-byte prefix/suffix guards; the fixture does not demand unaligned schedule support.
Implementation basis and limits: published factual vectors from OpenSSL 1.0.2u crypto/des/destest.c: https://github.com/openssl/openssl/blob/OpenSSL_1_0_2u/crypto/des/destest.c . No OpenSSL implementation was copied. Existing host key setup uses the default unchecked mode, consistent with DES_check_key defaulting to zero in https://github.com/openssl/openssl/blob/OpenSSL_1_0_2u/crypto/des/set_key.c . This does not establish PS5 key-schedule layout, checked-key policy, other cipher modes or game compatibility.
Integration review: the exact topic head was checked with the repository overlap tool against main
4c7d275bef89d309313d16bc2bc05d37a1b50be2. The tool reported shared CMake registration files in older PRs that already conflict with main: #9446, #9448, #10448, #10450, #10477, #10478, #10481, #10482, #10483, #10485, #10486, #10488, #10508, #10571, #10834, #10878, #10915, #11003, #11128, #11129, #11138, #11143, #11146, #11151, #11175, #11176, #11359, #11466. Their scoped file diffs were reviewed separately. 14 file comparisons could be projected onto the audit base and then combined with this topic without a new file conflict. 14 peer file changes already conflict with main and are not described as automatically mergeable; their registration changes were inspected directly. These peers do not provide this feature or test matrix. This uses a separate test/registration block and has no functional landing-order dependency. If a shared registration file changes before landing, this branch will need its affected merge and test checks refreshed. All 20 topic commits also merged independently into current validation main4c7d275bef89d309313d16bc2bc05d37a1b50be2; their combined integration2a0489dd307a9c98b9b353ea7282b65809db07ddwas built and tested. Depends on: none; no other candidate branch is required to build or exercise this change.Tested
guest_libre_ssl_des_answers passed against the actual mbedTLS-backed library on Linux and Windows, no skips. Replacing the real encryption key setup with decryption setup caused this fixture to fail.
Topic head:
6d8a9646581d0a5a04db6e10717c75e6383db1f7, based onf88c86bf6cdd2c74bcdb31e45ba877d4993e62e5. Local platforms: Ubuntu/WSL GCC 15.2, CMake 4.2.3, Python 3.14.4; Windows MinGW GCC 15.2, CMake 4.3.1, Python 3.14.3. Applicable conventions, whitespace, script registration and current-main three-way merge checks passed. Linux full-product builds and subsequent focused library rebuilds were performed; Windows used the full configuration and the affected library/test targets. The combined 11 system-library CTests passed on both platforms. No game or PS5 measurement is claimed; macOS and hosted full-build CI are not reported as passed.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)