[bunbeans2-arch]

What

On Windows, std::tmpfile() returns NULL with errno 22 when %TEMP% contains a character outside the ANSI code page, as it does for a profile like C:\Users\Жанна on a code page 1252 system. There GetTempPathA returns ? in place of the character (#13083). The tests that capture output through a host scratch stream then abort with FileStream: null handle or cannot open a temporary file for stderr.

• New core/libs/tests/TemporaryFile.hpp: TemporaryFile::Open() creates a uniquely named file under std::filesystem::temp_directory_path() with _wfopen(..., L"w+bxD") (exclusive create, deleted on close, as tmpfile does). Other hosts still return std::tmpfile(). It does not include windows.h.
• The 15 test files replace each std::tmpfile() with TemporaryFile::Open() (60 calls) and include the header. No other line changes.

core/libs/tests/GuestSyslog.cpp, the 16th test in #13083, is left out: #9929 rewrites the lines around its std::tmpfile() call. It can switch to the helper after #9929 merges.

No production code changes.

Tested

Windows 11 Pro 10.0.22631 (code page 1252), i9-9900K, MSYS2 UCRT64 GCC 16.1.0, Ninja, Release, BUILD_TESTING=ON. The 16 test targets were built on main f6fddd6 and on this branch, and the 16 tests ran with ctest -j 2 -R '^(guest_binary_word|...|guest_filesystem)$'.

TEMP and TMP	main f6fddd6	this PR
...\zh_Ж (outside code page 1252)	16 of 16 fail, 3 of 3 runs	15 of 15 changed tests pass, 3 of 3 runs; guest_syslog (unchanged) still fails
...\e_é (inside the code page)	16 of 16 pass	16 of 16 pass
normal profile TEMP	16 of 16 pass	16 of 16 pass

A standalone probe of the header with the same toolchain opened two distinct files under each of those three TEMP values, read back what it wrote, and left no anyps5-test-* file after fclose. After the 3 runs under zh_Ж, that directory held no anyps5-test-* file.

• python tools/check_conventions.py --base origin/main: all checks passed.
• python tools/pr_overlap.py --branch fix/tests-wide-tmpfile: one line conflict, GuestSyslog.cpp with fix(libc): restore syslog program-name fallback #9929, removed by leaving that file out. It also listed 11 PRs that conflict with main and share a file without a line comparison: feat(libc): scan 16-bit wide conversions on Linux #7386, fix(libc): support character reads from random device streams #8150, fix(libc): follow a Windows symbolic link before .. in a guest path #9371, fix(libc): share multibyte state in fgetwc #10405, fix(libc): reopen a stream onto /dev/random or /dev/urandom with freopen #10620, feat(libc): read 16-bit wide fields in fscanf on Linux #11724, feat(libc): accept positional arguments with wide scanf fields on Linux #11726, fix(libc): give an unbuffered stream FreeBSD's one-byte buffer on Windows #12057, fix(libc): validate null stream in ungetwc #12292, fix(libc): read wide scanf fields byte by byte, as titles' libc.prx does #12468, fix(libkernel): preserve DOS device names and trailing dots or spaces on Windows #12560.
• No overlap with fix(tests): pass guest_system_font, exec_arguments and unwrap_self under a non-ASCII TEMP on Windows #12993 or fix(diagnostics): open VideoOut telemetry and sampler files under any Unicode path on Windows #12996, which fix the in-code-page cases in other files.
• Not run here: Linux and macOS. The non-Windows branch returns std::tmpfile(), which is what the tests called before.

Checklist

• Based on current main; no other open PR implements the same functions
• One topic per PR; follow-ups go in a new PR
• No comments in code except technical debt
• Unimplemented paths throw (NotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file
• No notes, investigation .md files or images added to the repository (attach them to this PR)
• New third-party code is a submodule built from source
• Generic behaviour, not specific to one title
• Depends on: none (GuestSyslog.cpp is left out for fix(libc): restore syslog program-name fallback #9929)
• Fixes: none (15 of the 16 tests in Tests: 16 tests abort when TEMP has a character outside the ANSI code page (host std::tmpfile returns NULL) #13083; guest_syslog follows after fix(libc): restore syslog program-name fallback #9929)
• Unblocks: none
• GPUs tested: n/a
• AI-assisted: yes (Claude Code)

🤖 Generated with Claude Code

[github-actions]

Other open pull requests touch the same code. Merging one will break the other, or both implement the same thing. If this one builds on them, list them in Depends on.

Pull request	Conflicting files (lines on main)	Same exports	Same new files
PR 12468	core/libs/tests/GuestWideStreamScan.cpp L3
PR 13119	core/libs/tests/FileStreams.cpp L132-133
PR 13531	core/libs/tests/FilePosition.cpp L24-25

Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.

Pull request	Shared files not compared
PR 7386	core/libs/tests/FileStreams.cpp core/libs/tests/GuestStdioVariadic.cpp
PR 8150	core/libs/tests/FileStreams.cpp
PR 9371	core/libs/tests/GuestFilesystem.cpp
PR 9863	core/libs/tests/GuestWideStreamScan.cpp
PR 10405	core/libs/tests/GuestStandardStreams.cpp
PR 10620	core/libs/tests/GuestFilesystem.cpp
PR 12057	core/libs/tests/FileStreams.cpp

[MarcZX10]

Reviewed — looks good

The Unicode-safe temporary-file helper is scoped to tests, and the exact-head diff and available Windows evidence show no blocking issue.

What I ran

Reviewed head 9ffb865109811c3c161159ebccce68373eed0d03 against PR base 886e6d752cfb41d8f634ca072f7ca1d9bee98f0d. The merge preview against current upstream/main 08a10d225306ad102b57408e2ef7566bcfb829b2 was clean (tree fe1282aef442de1c69531788583cc7a1ea9ef0b6). Diff and convention checks passed. I also checked the 11 shared-file comparisons flagged by the overlap workflow: each pairwise merge preview with the corresponding current PR head was clean. I did not build or run tests locally.

git merge-tree --write-tree upstream/main refs/remotes/upstream/pr13104
git diff --check upstream/main...refs/remotes/upstream/pr13104
python3 tools/check_conventions.py --base upstream/main --head refs/remotes/upstream/pr13104 --title 'fix(tests): open scratch streams under a Unicode TEMP on Windows' --body <(gh pr view 13104 -R boykopovar/AnyPS5 --json body --jq .body)

Results

Check	Result
Current-main merge preview	Clean; tree fe1282aef442de1c69531788583cc7a1ea9ef0b6
Diff check	Passed; no output
Repository conventions	Passed
Flagged overlap comparisons	All 11 pairwise merge previews clean
Hosted CI	Windows, conventions, intake, eligibility, labels and report passed; Linux and specialized jobs skipped
Windows Unicode-path tests	Author-reported: all 15 changed tests passed three runs under an out-of-code-page TEMP; the unchanged guest_syslog test still fails as reported

Unedited local check output

fe1282aef442de1c69531788583cc7a1ea9ef0b6
All conventions checks passed.
7386 e74db94b92ee9a1cabf15c9844e3e26becec2a28
8150 74942c47a4c5d4110013d00c16d8f19277584ef8
9371 cd32cee8d5105eca2986f14d759618216ec4b330
10405 255587cc8fd0180be8aed1787b3f4f2f82adf15e
10620 0cc80c6e6112f059662d4ce5e3ce933b91b4e6d7
11724 f97435f42e9d14b8667bf85648a5bf0de65cecd9
11726 3f845220c35773cda49734692c57e7ec4cb4915d
12057 4720b8de8391887560fbe70f2a2052907fa39b9d
12292 1e18a0e59e6a8fedb1b10d4de2d166d9c585bc26
12468 fd4439edb3c98e3e9cd808ef00f6d9e3487f4bea
12560 21ecce3834c01f0c693d8c1367adf302e3c53f0a

Findings

Blocking

None found.

Non-blocking

GuestSyslog.cpp remains on std::tmpfile() and is explicitly deferred until #9929 is resolved; the PR body accurately identifies that limitation.

Sources

• TemporaryFile helper at the reviewed head
• Microsoft CRT _wfopen mode documentation documents x as exclusive creation and D as automatic deletion when the file is closed.

Not verified

I did not compile or run the test suite locally. The Unicode-path tests and Windows build/test results above are reported by the PR author/hosted CI; Linux and macOS results are not provided.

[JJenkx]

Windows run of this head (9ffb865109), merged onto main 9624d8c6bb (clean merge, local only). Windows 11 Enterprise 10.0.22621, WinLibs GCC 15.2.0 UCRT r7, Ninja, Release, BUILD_TESTING=ON, no Vulkan driver visible. This PR changes tests only, so there is no negative control.

• 18 of the 19 ctest entries of the touched test executables pass 3 of 3 (ctest --repeat until-fail:3), none skipped.
• guest_filesystem fails, but at a check that fails the same way on main on this Windows build, not at any line this PR changes. I patched Check locally to record the line: merged-file line 1550, unlink_nid_postfix(danglingDirectoryLink...) == 0, guest errno 13. Unlinking a dangling directory symlink on Windows 11 22621 is fixed separately in fix(libkernel): unlink a dangling Windows directory link #12820 (the CI image, 26100, doesn't hit it). All five hunks this PR makes in GuestFilesystem.cpp are before line 550, so they ran before that check and passed.

No file overlap with #12993, which fixes guest_system_font, exec_arguments and unwrap_self under a non-ASCII TEMP, or with #12996 (VideoOut telemetry and the AGC worker sampler).

AI-assisted: yes (Claude Code).

[malekaifa]

Reviewed exact current head 0f880fe with an independent Windows Unicode-TEMP reproduction. This host's Windows ANSI code page is 1252. With TEMP=TMP=C:\tmp\zh_Ж, a baseline std::tmpfile() probe returns NULL with errno=22; the exact PR TemporaryFile.hpp compiled with MSVC 14.44 (/std:c++17) opens successfully, writes/reads 'hello', closes successfully, and leaves zero anyps5-test-* files behind. Current-main merge-tree and git diff --check are clean. Compared with MarcZX10's previously approved 9ffb865 head, 14 of the 16 PR files are byte-identical; the two changed files (FileStreams.cpp and GuestStandardStreams.cpp) only absorbed upstream test additions, and their current PR-only hunks remain mechanical std::tmpfile() -> TemporaryFile::Open() replacements. Hosted CI is restarting on this rebase. This adds direct ACP1252 evidence for the issue's out-of-code-page path case; no blocking issue found.

[adriadam10]

Checked the diff, the helper (exclusive create, delete on close, EEXIST retry, non-Windows path unchanged) and the Windows runs from @MarcZX10, @JJenkx and @malekaifa.
Added as our own commits on the branch:

• GuestStandardStreams.cpp: CheckGetcPutc and CheckUngetcEndOfFile, added on main after this branch's base, use TemporaryFile::Open().
• FileStreams.cpp: the two remaining std::tmpfile() calls from the original base, and the four added by fix(libc): preserve errno on stream scan input exhaustion #13025 (scan input failure errno checks).
  Merged after the full Linux and Windows Build of the new head.