Repository navigation
Conversation
Progress report (9f2b939 → eecab38)📈 System libraries: 30.02% (+0.04%, +21 implemented functions) ✅ 21 implemented
Changed libraries (implemented exports)
|
|
Windows run of this head (
AI-assisted: yes (Claude Code). |
|
@edubox thanks. The 21 names all hash to the expected NIDs, but the bundled module (the
The field reads and stores are small enough to implement directly on a matching layout. Where you'd rather not, please document the gap instead of pinning a throw. |
|
Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.
|
744f193 to
26623a0
Compare
|
Rebased onto current Verified on this exact head (Linux x86-64, GCC 16.2.1, Release):
AI-assisted: yes |
|
Rebased onto current Verified on this exact head (Linux x86-64, GCC 16.2.1, Release):
AI-assisted: yes |
25ab63e to
a0bc673
Compare
|
Rebased onto current Verified on this exact head (Linux x86-64, GCC 16.2.1, Release):
AI-assisted: yes |
|
Rebased onto current Focused tests pass: AI-assisted: yes (Claude Code). |
a0bc673 to
807e3b8
Compare
|
Rebased onto current
Head is now |
044e3fb to
30208c7
Compare
|
Rebased onto current
Head is now |
|
Rebased automatically onto current |
30208c7 to
2609de9
Compare
|
Rebased automatically onto current |
2609de9 to
990b0a0
Compare
|
Rebased automatically onto current |
0423039 to
68c7a3e
Compare
|
Rebased automatically onto current |
|
Rebased automatically onto current |
68c7a3e to
86bbf0c
Compare
|
Rebased automatically onto current |
13aaa08 to
d6eb561
Compare
✅ AMD GPU test: passedPR head
Unstable on main (5, these also failed in recent main runs on this machine; not counted against this PR)Failing on main too (10, not counted against this PR)Passed on retry (2, failed in the parallel run, passed when re-run with a 360 s timeout; not counted against this PR)Validation IDs already present on main (4 IDs in 812 tests)Skipped (71)ReproduceAutomated build and test on a contributor's AMD machine; it does not replace upstream CI. A new comment is posted for each new push. Full logs. |
|
Rebased automatically onto current |
d6eb561 to
9da2f25
Compare
|
Addressed at head |
✅ AMD GPU test: passedPR head
Unstable on main (1, these also failed in recent main runs on this machine; not counted against this PR)Failing on main too (12, not counted against this PR)Validated but not compared (67, not in the main baseline's validation pass)Validation IDs already present on main (4 IDs in 812 tests)Skipped (71)ReproduceAutomated build and test on a contributor's AMD machine; it does not replace upstream CI. A new comment is posted for each new push. Full logs. |
…rds fields The 15 response/model accessors now read the offsets and widths measured in the module bundled with PPSA21564/PPSA23732 (builds J03093737/J03341606) instead of throwing, and the request-body setters store the value plus an is-set flag. ParameterToGetBoardDefinition and ParameterToGetContainer now allocate a host implementation so setfields and the two Container setters can store through +0x8; setfields returns 0x80553502 before initialize and 0x80553503/0x80553504 when the string copy fails. The host allocator stands in for the module's LibContext allocator, which the debt records. The test pins the measured offsets, the is-set flags, the vector reference count increment and the parameter lifecycle/error codes instead of asserting throws or null-self success.
|
Rebased automatically onto current |
9da2f25 to
05f1a18
Compare
|
The review points are implemented at head Verified on this head: |
…aderboards # Conflicts: # core/libs/prx/libSceNpCppWebApi/Export.cpp # docs/dev/debt/libSceNpCppWebApi.md
|
Rebased the merge conflict onto current
Verified on the new head: |
…merged from main Co-authored-by: edubox <3165165+edubox@users.noreply.github.com>
|
Hi @edubox, main moved under this branch (#14136 gave the BasicPresence accountIdIsSet declaration a signature in Api.hpp), so I merged main into it. The one conflict was in libSceNpCppWebApi/include/Api.hpp: the merge keeps main's prototyped accountIdIsSet declaration and all of your Leaderboards and InGameCatalog declarations. #14136 also added four list-parser lines in Export.cpp that still used the old ParameterAllocationFailed name your branch renamed to ParameterOutOfMemory (same 0x80553504 value), so I switched those four to your name in a second commit. None of your own code changed, and the NpCppWebApi tests pass on the merged tree. |
…aderboards # Conflicts: # core/libs/prx/libSceNpCppWebApi/Export.cpp # docs/dev/debt/libSceNpCppWebApi.md
|
Merged current
Verified on the merge: |
What
Completes the remaining imported offline surface of
sce::Np::CppWebApi::InGameCatalog::V5andsce::Np::CppWebApi::Leaderboards::V1, 21 NIDs with no implementation:InGameCatalog::V5Container/Skuaccessors read the measured fields; the twoParameterToGetContainersetters store the value and an is-set flag through the implementation pointerLeaderboards::V1The offsets and widths come from the module bundled with PPSA21564/PPSA23732 (builds
J03093737/J03341606):Container::getIdis the pointer at +0x38,skusIsSetis the byte at +0x220,GetRankingResponseBody::getTotalEntryCountis the 32-bit value at +0x58 andRecordScoreRequestBody::needsTmpRankIsSetis the byte at +0x42, plus the other offsets recorded in the debt. The two parameters now allocate a host implementation of the module layout sosetfieldsand the Container setters can store through +0x8;setfieldsreturns0x80553502beforeinitializeand0x80553503/0x80553504when the string copy fails. The host allocator stands in for the module'sLibContextallocator.Tested
Linux x86-64, GCC 16.2.1, Release with
BUILD_TESTING=ON, rebased onmainab6f5d32ed:ctest --test-dir build -R '^guest_np_cpp_web_api': 11/11 passed, including the newguest_np_cpp_web_api_catalog_leaderboards. It pins the measured offsets, the is-set flags, the vector reference-count increment and the parameter lifecycle/error codes instead of asserting throws or null-self success.python3 tools/check_conventions.py --base origin/mainpasses.python3 tools/pr_overlap.py --branch feat/npcpp-catalog-leaderboards --jobs 32: no overlap with active open pull requests. The tool could not compare a set of stale pull requests that already conflict withmainincore/libs/CMakeLists.txt.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)