Repository navigation
Conversation
|
Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.
|
Collaborator
|
Closing: this PR does not match its description, and it duplicates #13387.
The UTF-16 transformation test described here is not in the PR. You are welcome to reopen, or open a new PR, with the test that matches the description. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds independent guarded runtime coverage for C-locale UTF-16 transformation capacities. Capacity-zero, exact/short/larger destinations, returned full unit lengths and complete output when capacity suffices. It does not assert unspecified destination contents when capacity is insufficient.
Implementation basis: Calls the actual production function(s) through the canonical public Api.hpp; expected results derive from constructed inputs, snapshots, membership tables or standard C++ algorithms. Public contract: https://github.com/freebsd/freebsd-src/blob/833d39bd2e38421a14ea489a956261a0fa993fbc/lib/libc/string/wmemchr.3.
Known limits: Tests valid live spans and buffers only; no invalid-pointer or undefined-overlap behavior is added. No PS5/title execution or firmware object layout is inferred. Uses the existing char16_t declaration, not host wchar_t; code units are opaque and this is not Unicode validation or a width measurement. Only the existing/default C-locale contract is exercised, not other locale collation. Insufficient-capacity transformation bytes are not asserted.
Source/schema: core/libs/prx/libc/src/Strings.cpp core/libs/prx/libc/include/Api.hpp
Exact topic head
ec2a173edd49e7f8ae7f91429ba04a70bcf2d9afis one independent commit on mainda026c70655a132031d45e2008c24f993870d801. The current-main repository overlap checker againstda026c70655a132031d45e2008c24f993870d801reported no confirmed overlap. It could not finish comparisons for these older PRs already conflicting with main: #5021, #6085, #7081, #7447, #7715, #8150, #8965, #11628, #11661, #11689, #11698, #12688, #12700, #12965. Their shared-file diffs were reviewed separately. 12 scoped file changes projected onto main and then combined with this topic without a new conflict; 2 peer file changes already conflict with main and are not claimed automatically mergeable. They do not provide this command or test matrix. Registration uses a separate target/name and there is no landing-order dependency. Changes to shared registration before landing need a refreshed merge/test check. Depends on: none. The twenty current topic heads are also merged into tested integration3990a2bd7e0abeaaeeef963a30a3d6508d9b5be3.Tested
Topic head:
ec2a173edd49e7f8ae7f91429ba04a70bcf2d9af. Combined integration:3990a2bd7e0abeaaeeef963a30a3d6508d9b5be3, based on mainda026c70655a132031d45e2008c24f993870d801. Ubuntu/WSL GCC 15.2, CMake 4.2.3, Python 3.14.4; Windows MinGW GCC 15.2, CMake 4.3.1, Python 3.14.3.The registered test calls the actual libc through canonical headers, using OS-protected pages and real input/output buffers. A separate exact-head control compiled the whole relevant production source unit with this fixture: unchanged production code passed, and the fixture rejected an intentional production-function defect. This is a source-unit control, separately from the product build below.
Registered CTest
guest_wide_transform_boundarypassed on Linux and Windows as part of the filtered twenty-topic run:ctest --test-dir <build> -R <20-topic-pattern> -j 8 -V --output-on-failure, 20/20 passed on each platform, zero skips.cmake --build <linux-full-build> --parallel 8: complete default Linux product build passed. Windows used the full configuration and built the sixteen affected libc test targets plus relinker with--parallel 8; a complete default Windows build is not claimed. Conventions, whitespace, script registration and the public-header declaration/umbrella audit passed. No PS5, title or GPU validation run is claimed. macOS, WASM execution and hosted full-build CI are not reported as passed.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)