Repository navigation
Conversation
|
Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.
|
|
Integrated the existing shared CI fix at new head #13220's original commit Fresh local verification:
Hosted-check snapshot at 2026-10-30T17:37:44+00:00 (UTC): 5 pending. Current-head checks. Earlier red checks belong to heads without the prerequisite; new-head CI remains pending until it completes. Please re-check this integrated head. AI-assisted: yes. |
|
#13220 merged at 2026-11-01T03:58:51Z; the checklist now declares Depends on: none. Its exact original commit Refreshed this branch on recorded main Fresh Windows/MinGW and Linux builds at combined commit Please recheck this updated head. New hosted checks were triggered; they are not claimed passed until complete. Current-head checks. AI-assisted: yes. |
What
Adds independent guarded runtime coverage for in-range decimal integer parsing. atoi/atol/atoll receive valid terminated decimal strings at protected boundaries, both signs, C whitespace and trailing non-digits. All values fit signed 32-bit, avoiding overflow-policy and LP64/LLP64 assumptions.
#13220 merged at 2026-11-01T03:58:51Z. Its original commit
e9f09f54fabb6408d3e2711b8df10c10112ab00eremains an ancestor; this independent topic now has no open prerequisite. The earlier shared write-watch configuration fix is already on main and is not a separate feature of this topic. This branch is refreshed on recorded current main to clear the reported conflict state; the topic fixture is unchanged.Tested
Exact published head
4d8c6ec59c1dbf5558a3e5f6f9b98006dbf99c4eintegrates recorded mainba627802e2210187d417deb64c8f2fed8e33011f. Combined validation commit5274df9b794f169968db9f9cca559e8bb844d1efcontains all 17 exact refreshed topic heads. Fresh Windows/MinGW and Linux native builds compile the 17 affected targets, three related string targets and real production library dependencies; all 20 actual registered CTests pass per OS, zero skips, includingguest_decimal_boundaryexactly once. Fixtures are byte-identical to the previous published heads and the combined tree. No assertion or timeout is weakened. This is focused native validation, not a complete default product, local macOS, PS5/title or GPU run. New hosted runs remain pending until complete.Current-main description conventions, whitespace of the proposed merge, exact prerequisite ancestry and unchanged-fixture checks pass. The dependency checklist is now none; historical mentions below describe the earlier open-prerequisite state.
Earlier rationale and validation (historical revisions and dependency state)
What
Adds independent guarded runtime coverage for in-range decimal integer parsing. atoi/atol/atoll receive valid terminated decimal strings at protected boundaries, both signs, C whitespace and trailing non-digits. All values fit signed 32-bit, avoiding overflow-policy and LP64/LLP64 assumptions.
Integrate the existing #13220 fix at
e9f09f54fabb6408d3e2711b8df10c10112ab00eand current recorded main. The failed macOS write-watch jobs stopped in CMake configuration because execute-fault and read-fault were each registered twice. This head includes the original prerequisite commit, removing the duplicate block while retaining all 18 distinct tests. No parallel fix is introduced, no test assertion is weakened, and no timeout is changed.This PR's fixture is byte-identical to the previous published head
a0f81fb1aec57c799893bc4d70bd2c896c777153. The extra topic-relative CI change is the existing prerequisite's five-line registration deletion. Proposed landing order is #13220 first, then this independent topic. The submitted head already includes the fix, so its new CI can test it while the prerequisite PR remains open.Original topic rationale and earlier overlap evidence (historical snapshots)
Adds independent guarded runtime coverage for in-range decimal integer parsing. atoi/atol/atoll receive valid terminated decimal strings at protected boundaries, both signs, C whitespace and trailing non-digits. All values fit signed 32-bit, avoiding overflow-policy and LP64/LLP64 assumptions.
Implementation basis: Calls the actual production function(s) through the canonical public Api.hpp; expected results derive from constructed inputs, snapshots, membership tables or standard C++ algorithms. Public contract: https://github.com/freebsd/freebsd-src/blob/833d39bd2e38421a14ea489a956261a0fa993fbc/lib/libc/stdlib/atoi.3.
Known limits: Tests valid live spans and buffers only; no invalid-pointer or undefined-overlap behavior is added. No PS5/title execution or firmware object layout is inferred. No overflow, error/errno, base-prefix extension or out-of-range return policy is asserted.
Source/schema: core/libs/prx/libc/src/Strings.cpp core/libs/prx/libc/include/Api.hpp
Exact topic head
a0f81fb1aec57c799893bc4d70bd2c896c777153is one independent commit on mainda026c70655a132031d45e2008c24f993870d801. The current-main repository overlap checker againstda026c70655a132031d45e2008c24f993870d801reported no confirmed overlap. It could not finish comparisons for these older PRs already conflicting with main: #5021, #6085, #7081, #7447, #7715, #8150, #8965, #11628, #11661, #11689, #11698, #12688, #12700, #12965. Their shared-file diffs were reviewed separately. 12 scoped file changes projected onto main and then combined with this topic without a new conflict; 2 peer file changes already conflict with main and are not claimed automatically mergeable. They do not provide this command or test matrix. Registration uses a separate target/name and there is no landing-order dependency. Changes to shared registration before landing need a refreshed merge/test check. The original functional-overlap assessment recorded no dependency at that earlier snapshot. The twenty current topic heads are also merged into tested integration3990a2bd7e0abeaaeeef963a30a3d6508d9b5be3.Tested
Exact submitted head
8165ef480879e5eed57eb8f631abc924aed02ec7. Recorded main6a3afa4deb18ea58a90efb8040fff8c60e4f2aab; prerequisite #13220e9f09f54fabb6408d3e2711b8df10c10112ab00e. Both and the previous published topic head are ancestors. The fixture and topic assertions remain unchanged.Fresh native validation uses combined commit
099d1af76d85818308412d7dd864f8bb4a1cd013, containing all 13 exact submitted heads, on Windows 11 / MinGW GCC 15.2 / CMake 4.3.1 and non-root Ubuntu 26.04 / WSL / GCC 15.2 / CMake 4.2.3. This is explicit combined-commit validation, not 13 separate native product builds. Every individual fixture blob matches that combined tree; pairwise main/prerequisite merges are clean.guest_decimal_boundaryis included exactly once. No timeout was raised.The combined native target build is not the complete default product build. No local macOS/WASM, PS5/title/GPU or firmware validation is claimed. Old red CI belongs to older heads without the prerequisite; new-head hosted CI starts after publication and remains pending until it actually completes. The prerequisite's external branch is unchanged.
Exact composition of the fresh native validation
#13310
ab8eeea15ea0dcb8aabe95e656a041963f8e4e8a, #133131ec676984f08d1ee65496d0d1c487a9fecb8ec49, #133141c8549945e9657645da7ce5a98693d50e85b5685, #13317442aef391ffaec2c9cfe1d098c84dde5f19cd292, #13319dab492c88b6bd8093c351b1726db02ad91af39ab, #13320f27454e88a02dd9c9f0510d3afb0aa72378f7e87, #133788bb9ed3e152ea1611fe8216f25dd03c7830f2818, #133799b39858ef369da4f3eb01e4137e3f932a478ebd2, #133806083413b06d03a34e498629da942b8ec40ab7a9f, #13381cf303f4142403e370f807813b99fc5aa087ad72b, #1339115fbf68aa97b2617cd03ae94f033020028edeac6, #13394cb3188c2b1f36700f882311191f86b897c4f01cb, #133958165ef480879e5eed57eb8f631abc924aed02ec7Earlier author-reported validation (historical heads; not new results)
Topic head:
a0f81fb1aec57c799893bc4d70bd2c896c777153. Combined integration:3990a2bd7e0abeaaeeef963a30a3d6508d9b5be3, based on mainda026c70655a132031d45e2008c24f993870d801. Ubuntu/WSL GCC 15.2, CMake 4.2.3, Python 3.14.4; Windows MinGW GCC 15.2, CMake 4.3.1, Python 3.14.3.The registered test calls the actual libc through canonical headers, using OS-protected pages and real input/output buffers. A separate exact-head control compiled the whole relevant production source unit with this fixture: unchanged production code passed, and the fixture rejected an intentional production-function defect. This is a source-unit control, separately from the product build below.
Registered CTest
guest_decimal_boundarypassed on Linux and Windows as part of the filtered twenty-topic run:ctest --test-dir <build> -R <20-topic-pattern> -j 8 -V --output-on-failure, 20/20 passed on each platform, zero skips.cmake --build <linux-full-build> --parallel 8: complete default Linux product build passed. Windows used the full configuration and built the sixteen affected libc test targets plus relinker with--parallel 8; a complete default Windows build is not claimed. Conventions, whitespace, script registration and the public-header declaration/umbrella audit passed. No PS5, title or GPU validation run is claimed. macOS, WASM execution and hosted full-build CI are not reported as passed.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)