Repository navigation
docs(libSceAudioOut): name what the emulators do with the length and frequency of sceAudioOutOpen - #13885
Merged
oneandonlydean merged 1 commit intoNov 1, 2026
Conversation
…frequency of sceAudioOutOpen Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
MarcZX10
approved these changes
Oct 31, 2026
MarcZX10
left a comment
Contributor
There was a problem hiding this comment.
Reviewed — looks good
The documentation-only change matches the exact-head implementation and the three pinned emulator revisions; I found no blocking issue.
What I ran
Reviewed head 28bd85cb7a90090757cf1322e9c1700a3bbd608f against base 8f55414024c614b32548254e59e80bd3f0085231; merge preview was clean. Environment: Linux x86_64, Python 3.11.2, GCC 12.2.0; no C/C++ compiler was used.
python3 -m unittest tools.tests.test_check_conventions_doc_links
git diff --check 8f55414024c614b32548254e59e80bd3f0085231...28bd85cb7a90090757cf1322e9c1700a3bbd608f
python3 tools/check_conventions.py --base 8f55414024c614b32548254e59e80bd3f0085231 --head 28bd85cb7a90090757cf1322e9c1700a3bbd608f --title 'docs(libSceAudioOut): name what the emulators do with the length and frequency of sceAudioOutOpen' --body /tmp/anyps5-pr-precheck/boykopovar-AnyPS5-pr-13885-28bd85cb7a90/pr-body.mdResults
| Check | Result |
|---|---|
| Documentation link tests | Passed, 6 tests |
git diff --check |
Passed, no output |
| Repository conventions and PR template | Passed |
| Hosted eligibility | Passed; product build jobs were skipped for this docs-only change |
| Source comparison | The PR’s statement matches the pinned emulator source and AnyPS5 implementation |
Unedited local test and convention output
......
----------------------------------------------------------------------
Ran 6 tests in 0.001s
OK
All conventions checks passed.
Sources
- AnyPS5
sceAudioOutOpenat the reviewed head checks zero length/frequency and does not impose the emulator length/frequency restrictions described in the new debt note. - shadPS4 at
0614ce324be092791b758d79f93d9f1ca5b10a81rejects lengths outside 256–2048 in multiples of 256; its sample-rate check accepts only 48000. - fpPS4 at
04cefd43e6fddd1ab033e7980cd356d14c964905applies the same enumerated lengths and 48000 frequency. - KytyPS5 at
5e837a9beac82c031868eaad9348d6a48245fb99rejects zero frequency and contains no length validation inAudioOutOpen.
Not verified
No C/C++ build or hardware/console behavior was tested. The new note explicitly says AnyPS5’s acceptance of nonzero lengths/frequencies has not been measured on hardware.
|
Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.
|
This was referenced Oct 31, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds one entry to the libSceAudioOut technical debt:
sceAudioOutOpenrejects only a length of 0 (SCE_AUDIO_OUT_ERROR_INVALID_SIZE) and a frequency of 0 (SCE_AUDIO_OUT_ERROR_INVALID_SAMPLE_FREQ) and accepts every other value, which is not measured on hardware. shadPS4 and fpPS4 (both PS4) return those errors for any length outside 256 to 2048 in steps of 256 and any frequency but 48000, while KytyPS5 (PS5) rejects a frequency of 0, as this library does, and checks no length, where this library rejects 0. The entry does not say which is right and no code or test changes. 44 of the 53 local titles importsceAudioOutOpen.Tested
Documentation only.
tools/check_conventions.py --base upstream/mainpasses. Based onmain833be4af8d, and it merges withmain602c0e417cwithout a conflict (checked 2026-10-31 11:00 UTC). I read the three emulators at the commits named in the entry (KytyPS5 5e837a9beac82c031868eaad9348d6a48245fb99, shadPS4 0614ce324be092791b758d79f93d9f1ca5b10a81, fpPS4 04cefd43e6fddd1ab033e7980cd356d14c964905) and oursceAudioOutOpeninAudioOut.cpp. I did not measure which lengths and frequencies the local titles pass.Overlap
Checked on 2026-10-31 at 08:02 UTC against
maina76a5f3 (1608 open pull requests). I took the changed files of each of the 1608 open pull requests fromgit diff --name-onlyagainst its merge base. Seven of them changedocs/dev/debt/libSceAudioOut.md: #13781, #13694, #13676, #12863, #12791, #12765 and #5021.git merge-treeagainst thatmain: this head alone merges cleanly, and so do its pairs with #13781, #13694, #13676, #12791 and #12765. The pairs with #12863 and #5021 conflict, but each of them conflicts withmainon its own. #13676 and #12765 are my own pull requests on the same file; they merge cleanly with this one in either order, so none has to go first. Checked once more on 2026-10-31 at 11:00 UTC againstmain602c0e417cwith this head: the same results for these seven, and of the 82 pull requests opened since 06:30 UTC only #13836 changes these files, and it merges the same with and without this change.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)AI-assisted (Claude Code).
🤖 Generated with Claude Code