Repository navigation
feat(share): answer sceShareSetContentParamForApplicationTitle - #1544
Conversation
d2f5dbe to
f20fcad
Compare
|
Other open pull requests touch the same code. Merging one will break the other, or both implement the same thing. If this one builds on them, list them in Depends on.
|
|
A title that calls this: Sonic Origins (PPSA05324) calls Bring-up thread: #2021 |
|
Please narrow this to |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
f20fcad to
eb1d558
Compare
|
Native Windows run, since no Windows results were posted. Setup: Windows 10 (19045), MinGW-w64 GCC 15.2.0 (WinLibs r7), Release. Head
No title was run. 🤖 Addressed by Claude Code |
|
Checked against KytyPS5 |
What
sceShareSetContentParamForApplicationTitlethrewNotImplemented_nid_no_patch. It now follows KytyPS5 (NIDORspsWDXPpsmatches KytyPS5's table): a null title returnsINVALID_PARAM(0x81960002) and any other title returns 0. Nothing is captured or shared, so the title has no effect. TechnicalDebt gains an entry for it.Sonic Origins (PPSA05324) stops at this call. NahuelGenchi reports that it calls it about 50 s in and stops with
sceShareSetContentParamForApplicationTitle not implemented, the messageNotImplemented_nid_no_patchthrows (blocker E in the bring-up thread, #2021; see the comment above). That run ismainplus local workarounds for the title's earlier stops (shader image heap capacity, a copy of a registered shader header, depth/stencil clear draws), so on unmodifiedmainthose come first.Narrowed at review: the first version of this PR also answered
sceShareCaptureVideoClipExtendedand gave libSceShare.native copies of libSceShare's bodies. No title reaches the first, and the copies in libSceShare.native are left out because #1538 builds native from libSceShare's sources instead. Both are removed, and the branch is rebased onmain, which resolves the TechnicalDebt conflict.Tested
macOS 27.0, Apple M3 Pro, Apple clang (arm64), Release.
maindoes not build on macOS yet, so this commit was tested onmainmerged locally with the arm64 macOS libraries (mugurc#3), with a local change to the loader'slink.hinclude that is not part of this PR.guest_share(GuestShare.cppagainst libSceShare) passes, including a title and a null title for the new call.tools/check_conventions.py --base upstream/mainpasses.tools/progress.py --compare: libSceShare gains 1 implemented function,sceShareSetContentParamForApplicationTitle.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed in TechnicalDebt.mdfiles or images added to the repository (attach them to this PR)🤖 Generated with Claude Code