Repository navigation
Conversation
…dow test In the unit shadow tests in Recorder.cpp, PublishShadow publishes unit 3, copying data into the host import and marking pages in unit 3 dirty under write-watch. A second retile on unit 3 then marks the range shadowed using the current tracker generation. Because the dirty pages from the prior publish were not collected before the second retile, the subsequent partial publish collected them, advancing unit 3's written stamp and causing changedUnits to falsely drop unit 3 as stale (BlockWritten). Collect writes across the import range prior to the second retile so that lingering dirty stamps from the previous publish are cleared. Closes boykopovar#1429.
Contributor
|
I checked this against current |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In the unit shadow tests in
core/libs/prx/libSceAgcDriver/tests/Recorder.cpp,PublishShadow(unit3, ...)at line 1437 publishes unit 3, copying data into the host import and marking pages of unit 3 dirty under write-watch. A second retile at line 1451 then re-marks unit 3 as shadowed usingTrackerGeneration().Because the dirty pages resulting from the prior publish were not collected before the second retile, the subsequent partial publish at line 1456 (
PublishShadow(unit3 + 100, ..., PartialUnits)) collected them, advancing unit 3's written stamp beyond its retile generation. This causedchangedUnitsto conclude that guest memory had been modified after the retile (BlockWritten), dropping unit 3 without copying it and returning 0 instead of 1.Collecting writes across the import range prior to the second retile clears the lingering dirty marks from the first publish, allowing unit 3's retile generation to stay current and the partial publish to succeed.
Closes #1429.
Checklist
python tools/check_conventions.py --base origin/mainunitShadowTestspasses lines 1456-1465)