Repository navigation
feat(libSceNpManager): keep the NP toolkit state callback slot - #16110
Open
MarrasFederico wants to merge 1 commit into
Open
MarrasFederico wants to merge 1 commit into
MarrasFederico wants to merge 1 commit into
Conversation
Progress report (fc23faa → 78cfa6a)📈 System libraries: 26.86% (+0.0053%, +2 implemented functions) ✅ 2 implemented
Changed libraries (implemented exports)
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
sceNpRegisterStateCallbackForToolkitandsceNpUnregisterStateCallbackForToolkitwere parameterless placeholders that threw. shadPS4 keeps one toolkit callback slot, separate from the other state callbacks: registering stores the callback and user data with no checks, and unregistering an empty slot returnsCALLBACK_NOT_REGISTERED.Both exports now do the same under the existing state-callback mutex. The callback type follows shadPS4's
OrbisNpStateCallbackForNpToolkit, the same shape asNpStateCallbackA.Not measured on a console.
Tested
Ubuntu 26.04.1, kernel 7.0.0, GCC 15.2.0, Release,
BUILD_TESTING=ON, on main6e6dae4e8b. Windows and macOS were not compiled here. No title was run.guest_np_managerpasses. New cases: unregistering before any registration, registering twice (overwrite), unregistering twice, and a null callback leaving the slot empty.(void)declarations, and the placeholders throw.check_conventions.py --base upstream/mainpasses.pr_overlap.py: #15580 and my #15203 also change the pending-export count line, and #15922 edits the top ofApi.hpp; none implements these exports. #14212 only respaces the debt file.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)