Repository navigation
Conversation
Contributor
Author
|
Windows check of exact head Setup: Windows 11 Enterprise 22621, WinLibs GCC 15.2 UCRT, Release, with its own source and build trees. The hosted Windows check does not run these tests on pull requests.
Line 256 is AI-assisted: yes. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Retain the supplied
LibContextpointer in each Matches model at root offset+0x08.MatchesFactoryCreatecurrently puts it only in the outputIntrusivePtr, leaving the model field zero. Native model construction writes both; the native deleter also reads the model field. This changes the shared constructor initialization, without changing allocation policy, exports or the existing context validation.Source: static inspection of the bundled
libSceNpCppWebApi.prxfrom PPSA21564 (RemovedPlayerFactory::createat0x140790, context store at0x1407e2) and PPSA05347 (create0xfb6c0, constructor chain ending at0xfb370, store at0xfb382, deleter0xfb7a0). Provider hashes and bounded observations are attached. This was not measured on a console. Custom allocator callbacks remain unimplemented and are documented in debt.This is independent of #16262 (occupied-output ownership) and #16128 (remaining factories). Both merge cleanly with this change; neither implements model-context initialization. There is no functional dependency. No title unblock or performance gain is claimed.
Tested
Windows qualification from our independent worker: exact
cad789a4ccmerged cleanly onto newer main87448b3c91asc7a0a64ee2, Windows 11 Enterprise22621/WinLibs GCC15.2 UCRT Release. All14 NP CPU tests pass three runs, zero skips. The same Matches fixture against that newer main code fails the +8 context assertion. Exact-head Windows result and main control. Linux qualification below uses its separate pinned base.Linux x86_64, Ryzen 7950X, GCC 16.2.1 Release C++20. Head
cad789a4cc921577acb5d39e1673fe7d93a55cfaon mainc36ab99c74cde292a75c75c6ab2dc989a047bb7d.c36NP library, fails at the missing-context assertion; restoring the candidate provider passes. Fixture/library hashes remain unchanged.1fa538392374dc3ffc7bb91aa2b7a8feee53808eand feat(np): implement remaining Matches2V1 factories and AppLauncher launch error #16128 atdd45a14c82b96e82e403a37147bf9740d6ae2ebd, combined head23dca4cfd221c5041cf7413d8faef603e32e9665: 13/13 selected NP CPU cases pass, zero skips. AppLauncher from feat(np): implement remaining Matches2V1 factories and AppLauncher launch error #16128 was not built/tested.The seven dependency provider libraries are frozen from previously qualified main
ef0d852; the NP module is freshly built from the pinned current sources. The Linux run is not a full SDK, console or title test; Windows evidence is separate above. No GPU test is needed for this CPU layout change.Source patch, CMake scope, logs/JUnit, negative control, exact pins and provenance, SHA-256
5da51c4d2c09d672079eee6361ee0e771373810a5fea50fcafab0f13d6857fed. No proprietary files are attached.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)