Repository navigation
Conversation
Implement ABI-sized source and listener parameter resets and boundary tests. Record the public-reference assumptions in TechnicalDebt. AI-assisted with Codex.
This was referenced Oct 8, 2026
9 tasks done
This was referenced Oct 9, 2026
Collaborator
|
Closing: no title is shown to reach |
ycbuzi
pushed a commit
to ycbuzi/AnyPS5
that referenced
this pull request
Oct 10, 2026
…sets Harvested from upstream (closed unmerged); library completion 2853/3243 -> 2855/3243. (changelog conflict: kept both) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011krDVCnnMQPaEFEqCDnKmA
9 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Implement the listener and source parameter reset exports in both NGS2 aliases. Correct the placeholder structures to the public 60-byte listener and 108-byte source layouts, write the complete defaults, and clear reserved fields. Geometry calculation and spatialization remain unimplemented.
ABI evidence: SharpProspero and KytyPS5. Defaults come from KytyPS5; hardware uncertainty is recorded in TechnicalDebt.
The overlap bot flags the shared
TechnicalDebt.mdinsertion line with #1616 and #1650. Their patches implement other functions and contain no NGS2 changes; this PR depends on neither.Tested
Exact published head:
50956d8dc0e3184013e289723b68eaf1d2441b71, based on upstreamce64d8eb3603078b597a60a37496328de63df72a. Windows x86-64, WinLibs MinGW-w64 GCC 15.2.0, CMake 4.3.1, Ninja 1.13.2, Release.Configured and built in a fresh isolated build directory. Full default build and
libsbuild passed. No AnyPS5 source or objects from the combined development checkout were reused; the pinned upstream FFmpeg package was reused read-only. All 1,629 compile commands were checked for source isolation. Test registration, conventions andgit diff --checkpassed; source remained clean and the head/tree matched before and after testing.All 10 NGS2 tests passed (0 failed, 0 skipped), including
ngs2_geometryandngs2_core_geometry. These check the complete output bytes, poisoned input, repeat resets, canaries and null rejection. The same regression previously failed against the untouched reset stub.Independent source/ABI/ownership review found no blocking findings. Defaults are based on the pinned public reference, not hardware measurement. Null-input console error precedence remains unverified. No PS5 hardware, retail-title or Linux runtime validation is claimed. This isolated run covers the NGS2 suites, not the full GPU suite. GitHub Actions currently requires maintainer approval; no hosted CI pass is claimed.
Checklist