Skip to content

feat(ngs2): implement geometry parameter resets - #1875

Closed
Albaloola wants to merge 1 commit into
boykopovar:mainfrom
Albaloola:contribution/ngs2-geometry
Closed

Albaloola wants to merge 1 commit into
boykopovar:mainfrom
Albaloola:contribution/ngs2-geometry

Conversation

@Albaloola

@Albaloola Albaloola commented Oct 8, 2026 •

Copy link
Copy Markdown

What

Implement the listener and source parameter reset exports in both NGS2 aliases. Correct the placeholder structures to the public 60-byte listener and 108-byte source layouts, write the complete defaults, and clear reserved fields. Geometry calculation and spatialization remain unimplemented.

ABI evidence: SharpProspero and KytyPS5. Defaults come from KytyPS5; hardware uncertainty is recorded in TechnicalDebt.

The overlap bot flags the shared TechnicalDebt.md insertion line with #1616 and #1650. Their patches implement other functions and contain no NGS2 changes; this PR depends on neither.

Tested

Exact published head: 50956d8dc0e3184013e289723b68eaf1d2441b71, based on upstream ce64d8eb3603078b597a60a37496328de63df72a. Windows x86-64, WinLibs MinGW-w64 GCC 15.2.0, CMake 4.3.1, Ninja 1.13.2, Release.

Configured and built in a fresh isolated build directory. Full default build and libs build passed. No AnyPS5 source or objects from the combined development checkout were reused; the pinned upstream FFmpeg package was reused read-only. All 1,629 compile commands were checked for source isolation. Test registration, conventions and git diff --check passed; source remained clean and the head/tree matched before and after testing.

All 10 NGS2 tests passed (0 failed, 0 skipped), including ngs2_geometry and ngs2_core_geometry. These check the complete output bytes, poisoned input, repeat resets, canaries and null rejection. The same regression previously failed against the untouched reset stub.

Independent source/ABI/ownership review found no blocking findings. Defaults are based on the pinned public reference, not hardware measurement. Null-input console error precedence remains unverified. No PS5 hardware, retail-title or Linux runtime validation is claimed. This isolated run covers the NGS2 suites, not the full GPU suite. GitHub Actions currently requires maintainer approval; no hosted CI pass is claimed.

Checklist

  • Exact branch head independently built and tested; base recorded above
  • Open-PR implementation overlap screened; documentation overlap disclosed above
  • One topic per PR; follow-up work is separate
  • No investigation notes or images added to repository source
  • Unsupported paths remain explicit failures; limitations are recorded in TechnicalDebt
  • New third-party dependencies, if any, are pinned submodules built from source
  • Generic behavior, not specific to one title
  • Depends on: none
  • AI-assisted: yes, with OpenAI Codex; the PR author remains responsible for the submitted changes

Implement ABI-sized source and listener parameter resets and boundary tests. Record the public-reference assumptions in TechnicalDebt.

AI-assisted with Codex.
@github-actions

github-actions Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Other open pull requests touch the same code. Merging one will break the other, or both implement the same thing. If this one builds on them, list them in Depends on.

Pull request Conflicting files (lines on main) Same exports Same new files
#1947 docs/dev/TechnicalDebt.md L40

@oneandonlydean

Copy link
Copy Markdown
Collaborator

Closing: no title is shown to reach sceNgs2GeomResetListenerParam or sceNgs2GeomResetSourceParam on main, and library functions go in when one does. Please reopen with the title ID and the log line if you find one.

ycbuzi pushed a commit to ycbuzi/AnyPS5 that referenced this pull request Oct 10, 2026
…sets

Harvested from upstream (closed unmerged); library completion 2853/3243 -> 2855/3243. (changelog conflict: kept both)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011krDVCnnMQPaEFEqCDnKmA
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants