Repository navigation
fix(tools): honor dependency declarations without a colon - #2263
oneandonlydean merged 1 commit into
Conversation
|
Additional platform validation on standalone PR head Windows: passed — Windows 11, supported WinLibs GCC 15.2.0 UCRT/POSIX/SEH r7; CMake 4.3.1 / Ninja. 50 Python unit tests plus all 4 |
|
The parser change and its dependency-specific regression cases look well scoped. The local Debian run and the Windows validation report provide useful evidence for the Python tool and its four CTest registrations. One repository-required check is still missing: the current PR check list contains only Conventions, while the full Linux/Windows Build and Linux/Windows/macOS relinker matrix have not run for head |
3777874 to
5fcac96
Compare
What
Honor the
Depends on #Nform documented in CONTRIBUTING when checking pull-request overlaps. The original checker recognized onlyDepends on:and missed the dependency declared in #1810.Keep colon declarations authoritative, including their multiline lists. When none is present, accept a plain declaration with inline references separated by commas or
and. Stop before other prose so an unrelated reference cannot hide an overlap.Eight regressions cover both declaration forms, CRLF, list boundaries, unrelated references, checklist precedence and dependency-based overlap suppression in both directions. Register them as
pr_overlap_dependencies, alongside the existing tooling tests. Upstream paginated REST retrieval, export detection, UTF-8 report writing and all other test registrations are preserved.Tested
Current head
5fcac960e8bbe7b7c24e57b3b0a1649adfee116bis one commit directly onmain57f96fd2b36563e8380c603a92b1ef0d9d3a6aa4, with no PR merge commits. This addresses the requested rebase. The rebased tree is identical to the previous branch merged with that main; the parser change and all eight dependency tests are unchanged.Private self-hosted Linux run
38074957306passed at that exact head, using reviewed workflow7b16e6c3d713427d815e7427aa77670d757b609donlab-github-actions-runner(Ubuntu 24.04 x86-64, GCC 13.3, CMake 3.28.3, Python 3.12.3):pr_overlapgroups passed;pr_overlap_dependenciestook 0.101 s.-B -W errorin 0.582 s, with a 30-second process deadline.hardware_oraclegroup reports one internal unittest skip out of 12; its non-verbose output does not retain the reason. CTest's zero skipped groups does not mean that subcase ran.Local macOS arm64, Python 3.12.14: all 60 Python tooling unit tests passed with
-B -W errorin 0.450 s at the current head, with a 30-second process deadline. Source/description conventions and whitespace checks passed. No local macOS C++ rebuild or local Windows run was performed for this rebase; upstream CI results follow.Automatic upstream Build run
38075121112completed successfully for head5fcac960. Its relinker jobs each verified that exact PR head and merged it intomain9c5d67fbe27518bb5485c34f2fdcfbcb249bd800before building: Linux 99/99, Windows 95/95, and macOS 92/92 CTest groups passed, includingpr_overlap_dependencieson all three platforms. These results apply to those CI merge builds. The full Linux and Windows runtime jobs were skipped, not validated by this run. The latest conventions check also passed.Earlier validation at
377787416695a7ff4e67ff8996ebae40482e8b33(before this rebase):38049954047: relinker-only Release build, 49 CTest groups and 50 Python tooling tests passed on Ubuntu 24.04 x86-64/GCC 13.3. The hardware-oracle group reported one internal unittest skip.ld.lldwas unavailable.pr_overlapCTest cases passed on that older standalone head. These are the contributor's results, not a locally reproduced Windows run or validation of the rebased head.Earlier validation against original base
d70b8998: the no-colon parsing and overlap-suppression regressions failed without the fix and passed with it. A read-only replay of 536 PR descriptions changed only #1810's parsed dependency set, from empty to{861}.The full Linux/Windows runtime jobs from the requested official Build workflow remain outstanding; its automatic relinker matrix is now complete. A collaborator with upstream write access must dispatch the full run for the rebased PR. Local relinker/tooling tests do not replace it. No full runtime build or title/homebrew execution is claimed for this tooling change.
Checklist
57f96fd2; one commit with no merge commits