Skip to content

feat(libc): implement abs #2316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
itsbo5 wants to merge 1 commit into from
Closed

feat(libc): implement abs #2316

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions core/libs/prx/libc/Export.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,12 +42,6 @@ int APS5_VABI libcCyberUnknown19(void) {
}


APS5_EXPORT("Ye20uNnlglA", libcCyberUnknown02);
std::uint64_t APS5_VABI libcCyberUnknown02(void) {
NotImplemented_nid_no_patch("Ye20uNnlglA");
return 0;
}

APS5_EXPORT("5Lf51jvohTQ", libcCyberUnknown03);
std::uint64_t APS5_VABI libcCyberUnknown03(void) {
NotImplemented_nid_no_patch("5Lf51jvohTQ");
Expand Down
2 changes: 2 additions & 0 deletions core/libs/prx/libc/src/Math.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ std::lldiv_t APS5_VABI lldiv_nid_postfix(long long numerator, long long denomina
return std::lldiv(numerator, denominator);
}

int APS5_VABI abs_nid_postfix(int j) { return std::abs(j); }

float APS5_VABI fmodf_nid_postfix(float x, float y) { return std::fmod(x, y); }
float APS5_VABI asinf_nid_postfix(float x) { return std::asin(x); }
float APS5_VABI acosf_nid_postfix(float x) { return std::acos(x); }
Expand Down
6 changes: 6 additions & 0 deletions core/libs/tests/GuestMath.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ int APS5_VABI __isnormal_nid_postfix(double);
int APS5_VABI __isnormalf_nid_postfix(float);
int APS5_VABI __isinff_nid_postfix(float);
std::lldiv_t APS5_VABI lldiv_nid_postfix(long long, long long);
int APS5_VABI abs_nid_postfix(int);
}
static void Require(bool value) { if (!value) std::abort(); }

Expand All @@ -55,6 +56,11 @@ static void CheckIntegerConversions() {
Require(result.quot * denominator + result.rem == numerator);
}
}
Require(abs_nid_postfix(0) == 0);
Require(abs_nid_postfix(42) == 42);
Require(abs_nid_postfix(-42) == 42);
Require(abs_nid_postfix(2147483647) == 2147483647);
Require(abs_nid_postfix(-2147483647) == 2147483647);
struct SignedCase {
const char* text;
int base;
Expand Down
Loading