Repository navigation
Conversation
Contributor
|
Tested on Linux (CachyOS x86_64, Intel RPL-S iGPU / Mesa 26.3.0-devel / Vulkan 1.4.363, GCC 16.2.1) at
LGTM! |
13 tasks
Contributor
|
Native Windows run, since no Windows results were posted. Setup: Windows 10 (19045), MinGW-w64 GCC 15.2.0 (WinLibs r7), Release. Head
No title was run. 🤖 Addressed by Claude Code |
Collaborator
|
Closing for the same reason as #2309: no title is shown reaching |
9 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Completes 100% export coverage for
libSceSigninDialog(7/7 functions):sceSigninDialogGetStatus,sceSigninDialogClose, andsceSigninDialogGetResultfollowing the common-dialog state machine (NONE->INITIALIZED->RUNNING->FINISHED), mirroringlibSceLoginDialog.sceSigninDialogGetResultreportsCOMMON_DIALOG_RESULT_USER_CANCELED(1) once finished, validating null pointer and uninitialized / unfinished states.sceSigninDialogClosesucceeds when initialized and validatesCOMMON_DIALOG_ERROR_NOT_INITIALIZED.core/libs/prx/libSceSigninDialog/CMakeLists.txtand a complete guest unit test suite incore/libs/tests/GuestSigninDialog.cpp.libSceSigninDialogin the silent stubs section indocs/dev/TechnicalDebt.md.Tested
python tools/check_conventions.py --base upstream/main.python tools/progress.py.GuestSigninDialog.cppdriving initialization, open, update/get status, get result, close, terminate, and argument errors.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed in TechnicalDebt.mdfiles or images added to the repository (attach them to this PR)