Repository navigation
fix(agc): build standalone visual test with required sources - #2426
Closed
AnzouBelilita wants to merge 4 commits into
Closed
AnzouBelilita wants to merge 4 commits into
AnzouBelilita wants to merge 4 commits into
Conversation
github-actions
Bot
added
the
intake paused
|
Thank you for your interest in the project! We are sorry, but we cannot accept more PRs while we work through the existing backlog. This PR has been automatically closed and labeled "intake paused". This is not a judgment of the quality of your changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR isolates the missing build dependencies and linkage required by the standalone AGC visual-test target.
shader_recompiler_agc_driver.main.Scope
This PR focuses on build wiring only. It does not claim to fix the existing GPU readback failure or verify that the AGC triangle is rendered correctly.
Validation
The target's source list, generated shader dependencies, and linkage have been checked against the existing build configuration. A fresh build and runtime verification are still required.
This is a focused follow-up to the feedback on #1907, avoiding unrelated runtime changes.