Repository navigation
fix(audio): export the sceAudioOutEx bitstream port functions - #2764
Merged
Merged
Conversation
Jelly5 (PPSA99505) imports sceAudioOutExGetMonitorInfo (PhnNN0UEV6Y), sceAudioOutExConfigureOutput (VcE+gXSwFXI), sceAudioOutExOpen (6X6dp+07h4U) and sceAudioOutExClose (0TfjSulCV2A) from libSceAudioOut and fails to load because no library exports them. It calls them only for its optional HDMI bitstream output, and their signatures are unconfirmed, so they are exported without an implementation and throw if they are called, like sceSaveDataCancel.
|
Thank you for your interest in the project! We are sorry, but we cannot accept more PRs while we work through the existing backlog. This PR has been automatically closed and labeled "intake paused". This is not a judgment of the quality of your changes. |
Contributor
|
Linux, since the description says it wasn't tested there. f2b4bf3 merged onto
Surround Sound Studio and Nuvio PS5 import these four as well as the |
9 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Jelly5 (PPSA99505) imports
sceAudioOutExGetMonitorInfo(PhnNN0UEV6Y),sceAudioOutExConfigureOutput(VcE+gXSwFXI),sceAudioOutExOpen(6X6dp+07h4U) andsceAudioOutExClose(0TfjSulCV2A) from libSceAudioOut and fails to load because no library exports them. It calls them only for its HDMI bitstream setting, which is off by default (jelly5_bitstream.cpp,settings.h). Their signatures are unconfirmed, so they are exported without an implementation and throw<name> not implementedif called, as ec2bb21 does forsceSaveDataCancel. TechnicalDebt records what Jelly5 and EVO-PLAYER-PS5 use them for. The newaudio_out_extest checks that each call reports not implemented.This was closed by the intake pause; the same branch and results are in #1578.
Tested
Windows 11 (WinLibs GCC 15.2.0 r7), Release, full build with
BUILD_TESTING=ONonmainb69270d:ctest -R audio_out --repeat until-fail:5: 8/8. These are the only tests that link libSceAudioOut. With a silentreturn 0and a wrong message planted,audio_out_exfails and names both.tools/check_conventions.py --base origin/mainandtools/check_test_registration.pypass.libSceAudioOut.prx, two runs each:mainstops atFAIL: unresolved ELF import PhnNN0UEV6Y from libSceAudioOut.prx; this branch stops atFAIL: unresolved ELF import oxMp8uPqa+U from libkernel.prx(pthread_set_name_np, feat(libkernel): implement pthread_set_name_np #1872).Not tested on Linux.
Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed in TechnicalDebt.mdfiles or images added to the repository (attach them to this PR)