Repository navigation
feat(libc): implement tzset - #3124
Merged
Merged
Conversation
Collaborator
|
Checked on Linux: |
9 tasks done
9 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Implements
tzset(gYFKAMoNEfo) in libc. It calls the host'stzset(_tzseton Windows), so a guest that changesTZand callstzsetgets the new zone fromlocaltimeand the other conversions, which already go through the host time zone.PS5MC (PPSA99420) stops at it on
mainf38a036 (catalog build,eboot.binandsce_module/libc.prxunwrapped as #2605 requires, with #1529 in; tracked in #1578):main, Linux:app.elf: symbol lookup error: app.elf: undefined symbol: gYFKAMoNEfoapp.elf: symbol lookup error: app.elf: undefined symbol: 0NJDcQ2B8vE(execvp, fix(libkernel): export execvp #2827)Tested
Linux (Ubuntu 24.04, GCC 13, Release) on f38a036:
guest_time_conversionpasses 5/5 (--repeat until-fail:5). The new case switchesTZfromUTC-2toUTC-5, callstzset, and checks that the epoch converts to 05:00 withtm_gmtoff18000; it fails iftzsetdoesn't re-readTZ.check_conventions.pypasses. Windows 11 (MinGW-w64 GCC 15.2 from WinLibs, Release):guest_time_conversion5/5 with no warnings, so theUTC-5case passes through_tzsettoo. The Windows loader reportsFAIL: unresolved ELF import 0NJDcQ2B8vE (execvp) from libkernel.prxfirst for PS5MC, onmainand with this PR, so it reachestzsetthere only once #2827 is in.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed in TechnicalDebt.mdfiles or images added to the repository (attach them to this PR)