Repository navigation
test(agc): split agc_driver_flat_apertures into six parts - #3217
Merged
adriadam10 merged 1 commit intoOct 11, 2026
Merged
Conversation
Co-Authored-By: Claude <noreply@anthropic.com>
Collaborator
Author
Contributor
|
Windows run, since the PR has no Intel or Windows results yet: Windows 11, WinLibs GCC 15.2.0 r7, Release, merged onto
Full AI-assisted (Claude Code); I ran this on my machine. |
This was referenced Oct 11, 2026
Closed
9 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
agc_driver_flat_apertures(added in #1190) has timed out on every Linux CI run ofmainsince it was merged (Timeout 120.09 sec, main run 38097151664).The test isn't hung; it's slow on lavapipe. Each of its 126 rows compiles its own shader, which takes 0.4–0.95 s per row on CI's lavapipe (Mesa 25.2.8,
/dev/udmabufdenied as on CI). The 120 rows that run there take 59 s on an idle machine and more than 150 s on a loaded one, against a 120 s CI timeout and the 30 s rule in CONTRIBUTING. On RADV the whole test takes 2 s.It's now registered as six tests,
agc_driver_flat_apertures_0…_5. Each runs--part K/6, every sixth row starting at row K, so they share the slow and fast rows evenly. This follows the patternagc_driver_constant_storealready uses for its variants. Run with no argument, the executable still runs every row. A malformed--partthrows.Tested
Linux (CachyOS), GCC 16, Release.
/dev/udmabufdenied,ctest --parallel 4as on CI: the six parts pass in 10.3–13.3 s each. The single test took 59–150+ s before.--part 6/6exits with 1.tools/check_test_registration.pyreports nothing built and not run, andtools/check_conventions.pypasses.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed in TechnicalDebt.mdfiles or images added to the repository (attach them to this PR)