Repository navigation
feat(libc): implement sqrt and sqrtf - #3233
Merged
Merged
Conversation
Co-Authored-By: Claude <noreply@anthropic.com>
Collaborator
Author
This was referenced Oct 11, 2026
9 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
sqrt(MXRNWnosNlM) andsqrtf(Q+xU11-h0xQ), imported fromlibSceLibcInternal, aren't exported. Since #1529 binds those imports to the system libraries on Linux, and withfrexplin since #3221, PokeMMO Prospero now stops onsqrtat load onmain:mainaac0f1b./app.elf: symbol lookup error: ./app.elf: undefined symbol: MXRNWnosNlM(sqrt)It imports
sqrtftoo, so both go in here.Both use the host's
std::sqrt. IEEE 754 requires square root to be correctly rounded, so the result is the exact one on every conforming host, the console included. That includes -0, infinity and NaN for negative arguments.Tested
Linux (CachyOS), GCC 16, Release.
guest_mathpasses. The new cases are compared bit for bit with values computed independently in Pythondecimal:sqrt(2)=0x3ff6a09e667f3bcdandsqrtf(2)=0x3fb504f3;sqrtof the smallest subnormal =0x1e60000000000000(2^-537);mainthe test doesn't link.sqrtthroughfloat, andsqrtfdropping the sign of -0.main's relinker and launched. It stops at load with the line above.tools/check_conventions.pypasses.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed in TechnicalDebt.mdfiles or images added to the repository (attach them to this PR)