Repository navigation
fix(pad): accept vibration mode 3 - #3727
Merged
Merged
Conversation
Broken Sword Reforged (PPSA21480) calls scePadSetVibrationMode(handle, 3) after scePadOpen and treats a failure as fatal (ps5_controls.cpp:19 "Sony call failed with code 80920001"). Modes up to 3 are accepted, 4 and above stay invalid. Co-Authored-By: xXPBSXx <20614131+xXPBSXx@users.noreply.github.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Collaborator
|
Checked on Linux: build and Added one commit: a TechnicalDebt line ("Unknown function info") for the unverified meaning of mode 3, since the only evidence is that PPSA21480 calls it and aborts on failure. Merging once CI is green. |
8 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Allows vibration mode 3 in
scePadSetVibrationModein libScePad.Broken Sword - Shadow of the Templars: Reforged (PPSA21480, Windows) calls
scePadSetVibrationMode(handle, 3)afterscePadOpenand aborts on failure (#3704):which is
PAD_ERROR_INVALID_ARG.scePadSetVibrationModepreviously accepted only modes 0 to 2.Modes 0 to 3 are now accepted, while 4 and above (and negative values) remain invalid.
guest_padis updated: asserts that mode 3 returns 0 and mode 4 returnsPAD_ERROR_INVALID_ARG.Tested
Export.cppsyntax check passes;GuestPad.cpptest asserts mode 3 is accepted (0) and mode 4 returnsPAD_ERROR_INVALID_ARG(fails onmainwhere mode 3 expectsPAD_ERROR_INVALID_ARG).python3 tools/check_conventions.py --base upstream/main: all checks passed.git diff --check: passes with no whitespace or style warnings.python3 tools/pr_overlap.py --branch fix/pad-vibration-mode-3: no overlap with open pull requests.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed in TechnicalDebt.mdfiles or images added to the repository