Repository navigation
fix(exports): export the calls PPSA29866 imports - #3819
Conversation
|
Other open pull requests touch the same code. Merging one will break the other, or both implement the same thing. If this one builds on them, list them in Depends on.
|
|
Run of PPSA29866 (Tomba! 2 SE), Windows, GCC, RTX 4080 SUPER, 150 s limit, on current main + this PR (#3819) + #3789 ( AI-assisted (Claude Code). |
|
Longer run of PPSA29866 (Tomba! 2 SE), Windows 10, GCC, RTX 4080 SUPER, a local stack of current What the logs contain (stdout 384 lines, stderr 18): shader disk cache lines (first 10 s: 135 hits, then 2 hits, 2 misses), a pipeline cache load, two save data mounts ( AI-assisted (Claude Code). |
|
Played by hand (not only a log run): PPSA29866 (Tomba! 2: The Evil Swine Return Special Edition), Windows 10, GCC, RTX 4080 SUPER, 600 s, with the same local stack as in the earlier comment (current What was seen (by eye and ear, frame counter and FPS from the window title):
Not isolated: which of the stacked PRs are needed besides this one (earlier finding: #3789 for AI-assisted (Claude Code). |
2435e03 to
a14c436
Compare
PPSA29866 (Tomba! 2) fails to load without these imports that no library exports. Their signatures are unknown, so they are declared without parameters and throw until they are implemented. Adds a TechnicalDebt entry. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
a14c436 to
0485570
Compare
What
Tomba! 2 (PPSA29866) fails to load because three imports have no export. This PR declares them without parameters as throwing stubs (signatures unknown), as #1347 did for PPSA01317:
libSceHmd2sceHmd2ReprojectionQuerySeeThroughBufferSizeAlignlibSceVideoOutsceVideoOutSetFlipMaster,sceVideoOutClearFlipMasterNames come from the aerolib NID list (
tools/nid_names.py). No test is added, since CONTRIBUTING says not to test that a symbol is exported; a TechnicalDebt entry lists the stubs. The title's other missing imports are covered by #3773 (PPSA07411) and #3537 (PS VR2). It replaces #3801, which was stacked on #3799 and so repeated its exports.Tested
libSceHmd2andlibSceVideoOutbuild;tools/check_conventions.py --base upstream/mainpasses. I searched the open PRs for these three names and found none.sceAgcDcbSetWorkloadsActiveis a separate matter).Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed in TechnicalDebt.mdfiles or images added to the repository (attach them to this PR)