[SandstromPL]

What

repository() in tools/check_conventions.py skips every changed path under 3rdparty/. That includes gitlinks, so a submodule added there without a .gitmodules entry passes. That is how the stray 3rdparty/imgui gitlink from ddf6b8c98 (#3470) reached main: Conventions run 38137041751 passed on that head at 11:50Z, and the PR merged at 11:51Z. Until #3511 removed it at 12:42Z, checking out main failed even with submodules: false. actions/checkout runs git submodule foreach, which stopped with fatal: No url found for submodule path '3rdparty/imgui' in .gitmodules. That broke the Conventions and relinker jobs of other pull requests, for example Conventions run 38137872909 on #3509.

A gitlink under 3rdparty/ that a pull request adds or changes now needs a .gitmodules entry with a path and a non-empty url, which is what a checkout with submodules needs. When the pull request changes .gitmodules, every gitlink under 3rdparty/ in the head is checked, so dropping an entry or its url is caught too. A missing one is reported as system-dependency ("submodule without a url in .gitmodules"). Gitlinks outside 3rdparty/ keep their existing report from #3667.

.gitmodules is read with git config --no-includes --blob <head>:.gitmodules, since git ignores includes there. A .gitmodules that git cannot parse leaves the changed gitlinks reported instead of crashing the check. On a pull request that touches neither, the check makes no extra git call.

Tested

Ubuntu 24.04, Python 3.12.3, git 2.43:

• All 15 tools/tests files pass, including 31 tests in test_check_conventions_comments.py.
  • test_thirdparty_submodule_remains_allowed now gives its submodule a .gitmodules entry, named differently from its path.
  • Two new tests cover a gitlink added without an entry and a url dropped from an existing entry. Both fail on main's checker.
• Replays with the patched checker against upstream history:
  • --base 6731a610e^1 --head 6731a610e^2 (fix(libSceNpTrophy2): return success from sceNpTrophy2ShowTrophyList #3470) reports 3rdparty/imgui; main's checker passes it.
  • build: remove accidental imgui gitlink #3511 (fab9f576a) passes.
  • Over every commit on main that changed .gitmodules or a 3rdparty/ gitlink, the only commit reported is ddf6b8c98.
• The output is identical to main's checker on all 7 open pull requests that touch 3rdparty/ or .gitmodules (feat(input): add native SDL input configuration with ImGui #674, feat(aot): discuss native ARM64 compiler architecture and integration #1835, feat(libSceUsbd): pass USB devices and transfers through to the host with libusb #3848, feat(libSceUsbd): add the transfer fill helpers and the synchronous bulk and interrupt transfers #3875, feat(aot): run source-built graphics on native Apple ARM64 #3891, fix(ssl): retain loaded certificate authorities #3897, feat(aot): derive guard sites from qualified image recipes #4156).
• Scratch repositories, run as CI runs it (work tree at the base):
  • a malformed .gitmodules and an empty url = are reported;
  • bumping a registered submodule and removing a gitlink stay silent.
• tools/check_conventions.py from main passes on this branch with this title and body.

Not covered: a gitlink whose entry is unchanged but whose URL is unreachable.

Checklist

• Based on current main; no other open PR implements the same functions
• One topic per PR; follow-ups go in a new PR
• No comments in code except technical debt
• Unimplemented paths throw (NotImplemented_nid_no_patch); silent stubs are listed in TechnicalDebt
• No notes, investigation .md files or images added to the repository (attach them to this PR)
• New third-party code is a submodule built from source
• Generic behaviour, not specific to one title
• Depends on: none
• AI-assisted: yes (Claude Code); I reviewed and tested every line

Generated with Claude Code