Repository navigation
test(net): look up the unresolvable name as an absolute name - #4406
Merged
oneandonlydean merged 1 commit intoOct 12, 2026
Merged
Conversation
guest_sce_net expects sceNetResolverStartNtoa and sceNetResolverStartNtoaMultipleRecordsEx to fail for guest-sce-net.invalid. The resolver delegates to the host's getaddrinfo, which retries a name that is not found with the host's DNS search domains. On an ordinary home network whose router sets a search domain that answers any name, the lookup then succeeds as guest-sce-net.invalid.<search domain> and the test aborts. Use the absolute name guest-sce-net.invalid. so the host applies no search domain and the lookup fails on any network. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
guest_sce_netexpects the resolver to fail forguest-sce-net.invalid. The resolver delegates to the host'sgetaddrinfo, which retries a name that is not found with the host's DNS search domains. On an ordinary home network whose router sets a search domain that answers any name, the lookup succeeds asguest-sce-net.invalid.<search domain>and the test aborts atGuestSceNet.cpp:515.The test now uses the absolute name
guest-sce-net.invalid., so the host applies no search domain and the lookup fails on any network. Like #2894, this makes the test independent of the host network; the resolver is unchanged.Note for #3728: it adds another lookup of
guest-sce-net.invalidand would need the same trailing dot.Tested
Debian 13, GCC 14.2, Release, on an ordinary home network whose router sets such a search domain:
guest_sce_netaborts onmainand passes with this change.getent hosts guest-sce-net.invalidresolves there through the search domain, whilegetent hosts guest-sce-net.invalid.fails.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed in TechnicalDebt.mdfiles or images added to the repository (attach them to this PR)