Repository navigation
Conversation
Collaborator
|
Closing: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The overlap scanner fails with
JSONDecodeError: Extra datawhen GitHub CLI returns more than one page of PRs.gh api --paginateemits separate JSON documents for each page, butopen_prsparses its entire output as one document. Request--slurpand flatten the resulting page arrays. The previous test double returned one flat array and concealed the failure; update it to the real response shape.The response contract is documented in the GitHub CLI API manual.
Tested
Windows 11, Python 3.13. A fixture matching the documented CLI contract supplies 201 PRs over three pages: it fails on the base with
Extra dataand passes with the fix, retaining the final PR's head and dependency. No liveghinvocation or game files needed.Checklist
main; no other open PR implements the same fix