Repository navigation
Conversation
…n the arena Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
10 tasks done
10 tasks done
Contributor
|
Windows test of #4660 (MinGW GCC, Release, Windows 10, RTX 4080 SUPER,
Not tested: the skip path was not forced here. AI-assisted (Claude Code). |
|
Other open pull requests touch the same code. Merging one will break the other, or both implement the same thing. If this one builds on them, list them in Depends on.
|
7 tasks done
Contributor
Author
|
Closing in favor of #4746, which reserves the host hole so the check runs on every start instead of being skipped. The Windows results are in #4746 (comment). Written with AI assistance. |
This was referenced Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
agc_driver_graphicssometimes fails on Windows withwrite-watched arena contained no host exclusion to test, fromhostWriteWatchExclusionTestsinBdaResources.cpp(#3594). The check needs a host region inside the guest arena, and whether there is one depends on the process's address layout.mainruns. Its host regions are whatever the process had already mapped in [0x2_0000_0000, 0xFC_0000_0000). In my runs they were 2 MiB private reservations with a few committed pages, at addresses that changed with every start.Arena()(a local change, not part of this PR) over 200 starts ofagc_driver_graphics_tests.exeonmain2a5eca1. 5 starts had no host region; the others had 14 to 16. Those 5 starts fail the check.The check now prints that the arena host holes were not tested when there is no host region, as the file already does when write watch or the arena is unavailable. When there is one, which is most starts, it runs as before. The host heap checks after it always run.
Tested
Windows 11 (26200), WinLibs GCC 15.2.0 r7, Release, CI configure flags,
main2a5eca1, an RTX 4070 Laptop GPU and an Intel Raptor Lake-S iGPU.agc_driver_graphicstwice on the RTX 4070 in my runs of two unrelated pull requests, which don't touch the arena. On plainmainit passed 25 of 25 runs on each GPU, which fits a rate of about 2.5 %.agc_driver_graphicspasses on both GPUs with--repeat until-fail:3.agc_driver_graphicspasses on both GPUs.tools/check_conventions.py --base origin/mainpasses, andtools/pr_overlap.pyfinds no overlap with open pull requests.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed in TechnicalDebt.mdfiles or images added to the repository (attach them to this PR)🤖 Generated with Claude Code