Repository navigation
fix(input): read the input file from paths with non-ASCII characters - #4703
Merged
adriadam10 merged 1 commit intoOct 14, 2026
Merged
Conversation
Collaborator
|
Checked the diff, built it merged onto main and ran the libSceVideoOut ctest set ( |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
|
Rebased onto current main: the only conflict was in |
adriadam10
force-pushed
the
fix/input-config-non-ascii-path
branch
from
October 14, 2026 16:55
d3f409f to
b8ed789
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
ANYPS5_INPUT_CONFIGis read withstd::getenv, which returns the ANSI code page on Windows. A path containingüfails with "Cannot convert character sequence: Illegal byte sequence" while the path is built, which stops input initialization; a path with日本arrives as?and cannot be read. (With GCC 15 libstdc++ on MinGW,std::filesystem::path(const char*)treats narrow text as UTF-8, so theSDL_GetBasePathdirectory was already found; only the environment variable was broken.)_wgetenv; elsewhere as UTF-8.SDL_GetBasePathdirectory is converted from UTF-8 explicitly.Test (
pad_input_mapping): a temp directory named withüand日本holds an ini that is read throughANYPS5_INPUT_CONFIG; a parse error and a missing file name the path in UTF-8.docs/user/INPUT_MAPPING.mdnotes that paths may contain any characters.Tested
Not tested in a title; no game was run. Windows 11 build node (WinLibs GCC 15.2.0, Release,
BUILD_TESTING=ON): full build and the non-GPU ctest set, includingpad_input_mapping.tools/check_conventions.py --base origin/mainpasses.Checklist
main; no other open PR implements the same functions (feat(input): add native SDL input configuration with ImGui #674 edits bindings through an ImGui editor, feat(input): add browser-based input mapping configurator #3456 is a browser editor for the ini, feat(libSceVideoOut): capture the host cursor for guest mice and scale their deltas #4217 captures the host cursor for guest mice; none changes the analog conversion)NotImplemented_nid_no_patch); silent stubs are listed in TechnicalDebt (none added).mdfiles or images added to the repository🤖 Generated with Claude Code