Repository navigation
feat(libSceHttp): accept sceHttpSetCookieEnabled with cookies enabled - #4713
Closed
pietroma90 wants to merge 1 commit into
Closed
pietroma90 wants to merge 1 commit into
pietroma90 wants to merge 1 commit into
Conversation
sceHttpSetCookieEnabled threw for enable=1. The offline HTTP backend has no cookie engine and no request reaches the network, so the setting has nothing to apply to, as for the other offline setters such as sceHttpSetAutoRedirect. Both 0 and 1 now return 0; other values still return the invalid-value error. Update the offline-imports test and the libSceHttp technical debt entry.
This was referenced Oct 12, 2026
pietroma90
force-pushed
the
feat/http-cookie-event-error-font-textcodes
branch
from
October 12, 2026 19:44
4788027 to
11eb35f
Compare
pietroma90
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
sceHttpSetCookieEnabledthrew forenable=1. The offline HTTP backend has no cookie engine and no request reaches the network, so the setting has nothing to apply to, as for the other offline setters such assceHttpSetAutoRedirect.Both 0 and 1 now return 0; other values still return the invalid-value error. The offline-imports test and the libSceHttp technical debt entry are updated accordingly.
Tested
Windows 11, MinGW-w64 GCC 15.2.0 (WinLibs r7), Release build with
BUILD_TESTING=ON.guest_offline_importspasses with the newsceHttpSetCookieEnabled(1, 1) == 0check.ctest -j 8: 995 of 995 passed, 7 skipped (video_out and AGC tests that need Vulkan).python tools/check_conventions.py --base origin/mainpasses.No title or homebrew was run. Linux was not tested.
Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository