Repository navigation
build(agc): link the graphics and BDA device tests against libSceAgcDriver - #5108
Merged
adriadam10 merged 1 commit intoOct 13, 2026
Merged
Conversation
…river Co-Authored-By: Claude <noreply@anthropic.com>
9 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Follow-up of #5106 for the two other test executables that compiled driver sources again:
agc_driver_graphics_tests(29Graphics/srcand 2Execution/srcsources, the generated shader headers, plus BufferPool, TextureDetilerDescriptors, TextureCache and GpuColorTransfer fromPostCompile.cmake) andagc_driver_bda_device_tests(8 driver sources plus BufferPool and GpuColorTransfer). Every one of them is already inlibSceAgcDriver. Both now build only theirtests/files and linklibSceAgcDriver; the recompiler include directories come fromshader_recompiler_agc_driver's interface property instead of linking a second copy of the recompiler. About 45 compiles fewer per configuration.Tested
Linux, GCC, Release: both executables build and link. The 5 tests that run them (
agc_driver_graphics,agc_driver_bda_device,agc_sparse_buffer_holes,agc_descriptor_pool_reset_failure,agc_compute_descriptor_layout_flags) pass on RADV and on CI's lavapipe (25.2.8,GALLIUM_OVERRIDE_CPU_CAPS=avx,ANYPS5_REQUIRE_VULKAN=1).Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)