Repository navigation
feat(agc): count which key component differs on resource-content cache misses - #5408
Merged
adriadam10 merged 3 commits intoOct 14, 2026
Merged
Conversation
…e misses Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
11 tasks done
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ISSES is set The per-miss component comparison allocates and walks the whole key, and it ran under APS5_PROFILE_DRAW as well, where it cost queue time on every resource-content miss. It now runs only with the trace variable, which is also the only one that prints its [keymiss] lines. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 14, 2026
Collaborator
|
Checked on Linux (GCC/Ninja, PR merged onto main): |
This was referenced Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
APS5_TRACE_RESOURCE_KEY_MISSES=1reports why a resource-content cache lookup missed, not just that it missed. On each miss, the new key is compared word by word with the last key of the same shader set. Each differing word is attributed to the component it belongs to:Every 10 s it prints one line per draw/dispatch:
It also prints up to 256 per-miss lines, at most 4 per shader set, naming the components that changed.
This complements #5364, which traces draw-key misses. This PR covers the resource-content key, which is the one that decides whether a draw or dispatch re-records its descriptor contents. For #5345 the question is which part of that key changes from frame to frame: a buffer base address (word 0), a size or stride (word 2), or the layout itself. That decides whether masking a component in the key is worth trying. Off by default; no behaviour change without the variable.
Tested
tests/KeyMiss.cpp:Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)🤖 Generated with Claude Code