Repository navigation
Conversation
10 tasks done
|
Other open pull requests touch the same code. Merging one will break the other, or both implement the same thing. If this one builds on them, list them in Depends on.
|
4 tasks done
11 tasks done
11 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
pthread_attr_get_npleaves the destination attribute's previous scheduling policy unchanged, andscePthreadAttrGetalways reports FIFO. Both now copy the thread's stored policy, so attribute queries agree with explicit or inherited creation and later successful scheduling changes.The regression queries both exports after RR creation and RR → FIFO → RR changes, preloading the destination with the opposite policy before each query. The policy snapshot follows FreeBSD 11.4's attribute query and scheduling update. The debt entry records that applying the same rule to the SCE query has not been measured on PS5 hardware.
Tested
Ubuntu 24.04, GCC 13.3, x86-64, entirely inside Docker Desktop.
dacd78525. A diagnostic run records incorrect policies in 10 of 12 queries.a0f5916a2; all production libraries and the relinker build successfully.ctest -R '^(guest_pthread_.*|guest_available_cpumask|guest_sched_priority|patched_libraries)$'.python3 tools/check_conventions.py --base origin/mainandgit diff --checkpass.No Windows, PS5 hardware, or title run was performed. This corrects reported guest metadata; it does not change host scheduling. The entire project test suite was not run.
Checklist
main; no other open PR implements this policy-query correction (checked the open PR list and adjacent feat(libkernel): implement pthread_setaffinity_np #4514, fix(libkernel): keep a finished Windows thread's stack until it is joined or detached #4563, fix(libkernel): inherit floating-point environment on Windows threads #4981, and fix(libkernel): give an inheriting thread its creator's priority #5230 diffs).mdfiles or images added to the repository