Repository navigation
Conversation
…le-registry-lifetime
…le-registry-lifetime
10 tasks done
Merged
10 tasks done
11 tasks done
Collaborator
|
Closing: no title is known to reach this on current main (checked against PPSA21564's imports and runs). With the queue this high, please hold off on PRs that don't name a title needing the change. Reopen with the title ID and the log line if a title stops on it on current main. |
9 tasks done
11 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The dynamic loader's static module map destroys owned modules with dlclose during process exit. Guest finalizers can reenter module lookup while that map is partly destroyed; the image-ID map has already been destroyed as well. This caused a crash in module lookup during a guest finalizer.
Keep the registry and its mutex alive through process termination. Explicit dlclose still removes a handle and unloads outside the registry lock; remaining native modules are finalized by the host loader. Document the intentional retained allocation and untested Windows teardown ordering.
Add a Unix regression that loads libkernel after registering an exit callback. The callback checks symbol access, callable code, stable loaded-module and image identities, and explicit close after static teardown.
Tested
9265f4e551c5, containing maind1670009fbfd: Linux 1,038 passed / 46 skipped; Windows 714 passed / 389 skipped. Skipped cases remain unvalidated. The regression exercises Unix teardown; Windows teardown ordering remains unverified.Checklist